Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal font loaded at very small scale. #5230

Closed
kzhuangmc opened this issue Apr 3, 2020 · 10 comments
Closed

Terminal font loaded at very small scale. #5230

kzhuangmc opened this issue Apr 3, 2020 · 10 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@kzhuangmc
Copy link

Description of the new feature/enhancement

Feeling like the terminal row height could be reduced few pixels.
For comparison.
I have gnome terminal set up with font: Ubuntu Mono Regular, size 8
and windows terminal set up with font: Ubuntu Mono Regular: size 10.

First of all, despite these two terminals set with different font sizes, the font appears to be
the same viewing size. The different is windows terminal with size 10 is taller than gnome terminal with font-size 8.

@kzhuangmc kzhuangmc added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 3, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 3, 2020
@kzhuangmc
Copy link
Author

image

@DHowett-MSFT
Copy link
Contributor

Those are definitely different sizes.

Can you put gnome-terminal size 8 and Windows Terminal size 8 next to eachother? Then, can you do the same thing for size 10?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 3, 2020
@kzhuangmc
Copy link
Author

image

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 4, 2020
@kzhuangmc
Copy link
Author

kzhuangmc commented Apr 4, 2020

Per wikipedia, the font size 72 is roughly an inch. hence for size 8, it will be 1/9th of an inch.

So, I magnify the windows terminal size 8 to 900%, and measure is 7/8 inches. That missing 1/8th makes the difference.

image

@DHowett-MSFT
Copy link
Contributor

Then I'll need to know what your DPI is in Windows and in X11, because I'm willing to bet that our font size math isn't egregiously incorrect 😄

@kzhuangmc
Copy link
Author

Well, how about side by side comparison between windows terminal vs Notepad?

image

@DHowett-MSFT
Copy link
Contributor

Fair enough!

@parkovski
Copy link

Worth noting that X11 uses 72 DPI by default and Windows uses 96 - could explain why saving screenshots that look the same size on the screen come out as different image sizes.

@DHowett-MSFT
Copy link
Contributor

This difference is likely to be caused by hinting. Different text rendering engines handle hinting differently.

If you compare a font that isn't hinted:

(terminal in the back, notepad in the front)

image

If I overlay them ...

image

... the only difference is the subpixel antialiasing artifacts on the edges.

I'm going to mark this one as a /dupe of #1790 (sub #5093) because we're using that issue to track configurable font rendering knobs.

@ghost
Copy link

ghost commented Apr 7, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 7, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants