Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Cloud Shell device login reports itself as Visual Studio Code #2219

Closed
blowdart opened this issue Aug 3, 2019 · 4 comments
Closed

Azure Cloud Shell device login reports itself as Visual Studio Code #2219

blowdart opened this issue Aug 3, 2019 · 4 comments
Assignees
@DHowett-MSFT
Labels
Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal 1908.1

Comments

@blowdart
Copy link

blowdart commented Aug 3, 2019

Environment

Windows: 10.0.18362.267
Windows Terminal version: 0.3.2142.0

Steps to reproduce

Open cloud shell window
Perform device login

Expected behavior

Login text should name application as Microsoft Terminal.

Actual behavior

Login text which talks about logging into Visual Studio Code
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 3, 2019
@PankajBhojwani
Copy link
Contributor

This is a known issue! Will be fixed once the terminal has its own app ID that has been whitelisted by the Azure team

@DHowett-MSFT DHowett-MSFT added Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 5, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this Aug 5, 2019
@DHowett-MSFT
Copy link
Contributor

I'm on this.

@zadjii-msft zadjii-msft added this to the Terminal 1908.1 milestone Aug 5, 2019
@DHowett-MSFT
Copy link
Contributor

This is not a code change, but the pipeline has been updated to inject the WT application ID.

@DHowett-MSFT DHowett-MSFT added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 26, 2019
@ghost
Copy link

ghost commented Aug 27, 2019

🎉Windows Terminal Preview v0.4.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal 1908.1
Development

No branches or pull requests
4 participants
@blowdart @DHowett-MSFT @zadjii-msft @PankajBhojwani