Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - WSL based text rendering lag #2047

Closed
Sid911 opened this issue Jul 20, 2019 · 7 comments
Closed

Bug Report - WSL based text rendering lag #2047

Sid911 opened this issue Jul 20, 2019 · 7 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release Severity-Crash Crashes are real bad news.
Milestone

Comments

@Sid911
Copy link

Sid911 commented Jul 20, 2019

Environment

Windows build number: 18362.239
Windows Version: 1903
Windows Terminal version : 0.2.1831.0

Any other software?

Using WSL 1 with Ubuntu Distribution (just for info)

Steps to reproduce

This is the way I found it was most noticeable and also how I found it initially

  • Open Terminal
  • Open WSL Ubuntu using the options tab or type wsl.exe -d Ubuntu in CMD or Powershell
  • Install cmatrix using sudo apt install cmatrix
  • Type cmatrix to run.
  • See the laging behavior of the terminal.

Optional Reproducible Behavior

  • Now try to close the tab or application after running the cmatrix for a little while in full screen
  • The application Crashes or becomes unresponsive

This can also be seen a little bit when installing small files where ### lagS out significantly in WSL although I haven't noticed a crash just while installing things which is already rare compared to running cmatrix

Expected behavior

There shouldn't be any kind of this behavior where text lags out very well compared to other terminals. And it should defenitly not become unresponsive if we try to close the tab while doing so.

Actual behavior

Right now in its current State the Terminal uses very high resources while doing cmatrix, which is about 30% CPU usage OR more (depending on the size of the terminal). Which is higher than the number I saw with older versions of Terminal about 20-ish

It visibly lags while doing normal tasks like installing a package or any task where lots of lines update quickly, which kind of frustrating. A little bit but still.
In the case of crashing ** THE ENTIRE TERMINAL ** after trying to close the tab, I never did any serious task while executing "cmatrix" 😂😛 but that could end up very bad as the entire terminal crashes.

Here is one of multiple times it crashed.
image

Verifications

I have verified that its not my computer specific issue because cmatrix works like charm in other terminals like CMD, Powershell, Ubuntu Base Terminal, Hyper.

Correlating to that its not WSL issue because it works just fine on other terminals.
This is also a fresh install of windows, so I don't expect there are any issues here, not that it should matter.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 20, 2019
@DHowett-MSFT
Copy link
Contributor

I've also seen some crashes on rendering special characters. Perhaps cmatrix is just a fancy way to make us render special characters?

@DHowett-MSFT DHowett-MSFT added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 29, 2019
@EFanZh
Copy link

EFanZh commented Aug 4, 2019

I noticed that cmatrix runs slowly in Windows Terminal comparing to Alacritty.

Try the following command:

cmatrix -u0

In Alacritty I can get a smooth animation, but in Windows Terminal, the animation seems slow.

@zadjii-msft
Copy link
Member

We believe this is #2375

@dkambersky
Copy link

Fwiw I can't reproduce the slowdown on the 1910 preview release. Cmatrix appear to run normally now.

@skyline75489
Copy link
Collaborator

@dkambersky Thanks for the feedback! 1910 preview does include performance enhancement that's intended to make cmatrix great again.

@skyline75489
Copy link
Collaborator

Largely, this issue should be fixed. With a higher resolution and smaller font, the rendering pressure will be higher. And the cmatrix lag will be more likely to appear. But overall CPU usage is significantly lower.

@zadjii-msft
Copy link
Member

I'm going to close this one based off the excellent work @skyline75489 committed for 0.6, and other changes in that release that should have mitigated this crash. For any other persistent perf issues, I'll direct conversation to #1064.

Thanks all!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 28, 2019
@zadjii-msft zadjii-msft added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Tag-Fix Doesn't match tag requirements labels Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

6 participants