-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal Canary crashes when i merge a tab to another window #17246
Comments
Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! Closed similar issues:
|
For some reason closing or tearing off a tab leads to a call to
In the case of a single tab terminal window, there is no next tab, so the same tab (being replaced) receives the call. Note that the tab being torn off gets into the "detached" mode and has no |
That makes sense after i ran Windows Debugger on Terminal Canary:
|
Huh, this looks like it fails here:
And I can repro this even on #17251 branch. Maybe they are unrelated 🤔 After re-reading this from the first comment:
I believe there are two crash scenarios:
(1) is fatal, crashes the entire process taking down all the running terminal windows, and should be fixed by #17251. But (2) doesn't seem to crash the process or any running windows. You would only see the no-tab window to take a while before it disappears. I'm going to unlink this issue from #17251 because it doesn't fix all the issues. |
Is this issue older than Canary? I just had Terminal Preview (1.21.1272.0) crash when merging in a tab, though the reported versions don't seem to line up at all:
|
I mean, canary and preview forked off like, last week, so I'd fully imagine that whatever the root cause of this is, it's in Preview too. |
I tried to reproduce the issue again with Windows Debugger and that's what I got. However, this time, Terminal Canary just hangs, and it becomes unresponsive.
|
Hey does this still repro on a newer canary / main build? I just tried this again and I can't repro this anymore. I'm branched off 735ef28, more or less |
1.22.2321.0 is the latest version at the moment. |
@zadjii-msft I updated Terminal to 1.22.2321.0 and when I tried to tear the tabs again and it still crashes.
I'll try to run the Windows Debugger on Terminal Canary and see what's wrong. Edit: I tried to run Terminal Canary on Windows Debugger. The tabs tear are working just fine, but it's another error. I'm not sure if it's relevant to tabs or not. I hope that helps.
|
Windows Terminal version
1.22.1301.0
Windows build number
10.0.26212.5000
Other Software
No response
Steps to reproduce
Recording.2024-05-10.210951.mp4
Expected Behavior
I was expecting the dropped tabs to successfully merge with the first window without hangs or crash.
Actual Behavior
Two strange scenarios happen: Either the first window hangs but I successfully dropped the tab to the second window, or the entire Terminal hangs then crashes.
This doesn't always happen so I keep reproducing the bug. And according to Windows' Reliability History, the faulty module names were
Windows.UI.Xaml.dll
andMicrosoft.Terminal.Control.dll
I wanted to use Windows Debugger, but I couldn't get anything useful. Maybe I don't have enough experience with it. I'm sorry about that.
The text was updated successfully, but these errors were encountered: