Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidly clicking causing flickering of window focus #16737

Open
BPplays opened this issue Feb 19, 2024 · 4 comments
Open

rapidly clicking causing flickering of window focus #16737

BPplays opened this issue Feb 19, 2024 · 4 comments
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@BPplays
Copy link

BPplays commented Feb 19, 2024

Windows Terminal version

1.20.10303.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

rapidly clicking seems to cause flickering of window focus.
it seems to need precise timing to trigger, i've accidentally triggered it with a double click before

Expected Behavior

No response

Actual Behavior

click to watch:
click to watch

@BPplays BPplays added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 19, 2024
@carlos-zamora
Copy link
Member

carlos-zamora commented Feb 21, 2024

Thanks for filing! Does this happen regardless of what you're running inside terminal? Or when there's a specific number of tabs? Any 3rd party window management software? Can you also share your settings.json file/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 21, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2024
@carlos-zamora carlos-zamora added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting and removed Needs-Tag-Fix Doesn't match tag requirements labels Feb 21, 2024
@BPplays
Copy link
Author

BPplays commented Feb 21, 2024

this seems to only happen if you have a lot of tabs open i tested with 38 tabs just now and it worked but it might work with less.

im using DisplayFusion Pro 10.0 and PowerToys v0.76.2 FancyZones

settings.json

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 21, 2024
@carlos-zamora
Copy link
Member

Thanks! We've managed to reproduce it. Btw, your settings file is a work of art. Thanks :)

@carlos-zamora carlos-zamora added this to the Backlog milestone Feb 28, 2024
@carlos-zamora carlos-zamora added Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 28, 2024
@zadjii-msft
Copy link
Member

I'm guessing that this is pretty close to the same thing as #13771. From that thread:

This is fallout from the fix to #13589, more or less.

For whatever reason, the taskbar is restoring the hidden tool window ("pseudowindow") that's attached to the Terminal, rather than the actual Terminal window. Before we fixed #13589, the Terminal just wouldn't restore from the taskbar at all. Instead, we now can determine that the tool window got restored, and we send a signal to the Terminal to cause it to get restored as well. HOWEVER, we need to debounce these requests for various reasons. So there's a 200ms throttling that happens, which delays the restore (but also prevents CRAZY FLASHING) of the terminal window.

This is all fixed in Windows 11 (there, the taskbar just restores the Terminal's main HWND).

There's also #13388 and #13640 which are tracking additional weird bugs about this scenario. Considering we need to still figure out these last Windows 10 issues, I'm considering rolling them all into one thread.

I'm thinking in your case, because there's SO many tabs that are open, the delay between the first window changing state and the last one, is long enough that they get stuck in a loop.

Leonard just now was able to locally confirm this and noted that specifically the threshold for his machine was 32 tabs. Fewer than that - no repro. So wt -w 0 nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt;nt first to get into that state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants