Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimized terminal without explorer is not interactable #16635

Open
mybearworld opened this issue Jan 31, 2024 · 9 comments
Open

Minimized terminal without explorer is not interactable #16635

mybearworld opened this issue Jan 31, 2024 · 9 comments
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3)
Milestone

Comments

@mybearworld
Copy link

mybearworld commented Jan 31, 2024

Windows Terminal version

1.18.3181.0

Windows build number

10.0.22631.3085

Other Software

No response

Steps to reproduce

  1. Open WT
  2. Kill explorer.exe (taskkill -f -im explorer.exe)
  3. Minimize the window
  4. Try interacting with the maximize, restore and close buttons

Expected Behavior

The buttons work. The window is draggable, as with other apps.

Actual Behavior

The buttons don't work. The window isn't draggable.
The window is restorable by Alt+Tab or enabling quake mode, for instance, though, as expected.

@mybearworld mybearworld added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 31, 2024
@zadjii-msft
Copy link
Member

Okay so this might be a dumb question - how are you interacting with a minimized window, if explorer is dead (and presumably, there's no taskbar)/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 31, 2024
@mybearworld
Copy link
Author

When a window is minimized without explorer active, it turns into this:
A pill with just the Windows Terminal icon, a Restore, Maximize and Close button.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 1, 2024
@mybearworld mybearworld changed the title Terminal isn't restorable without explorer Minimized terminal without explorer is not interactable Feb 1, 2024
@zadjii-msft
Copy link
Member

HuhGIF

It does? I've never seen that before and I can't repro that now. That does look like the "iconified" state of the HWND, but typically iconified HWNDs are placed off at (-3200, -3200) IIRC.

Do you know if that's actually a Terminal HWND - for like, windowsterminal.exe? I have a sneaking suspicion that the hwnd there is actually OpenConsole.exe (though, I guess that would have the old conhost icon, not the Terminal one...).

Is there anything else running on your PC that might be messing with HWNDs? PowerToys? AHK?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Area-Windowing Window frame, quake mode, tearout and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 1, 2024
@mybearworld
Copy link
Author

Both PowerToys and AutoHotKey are running, but the same thing happens even after killing those two.

Do you know if that's actually a Terminal HWND - for like, windowsterminal.exe? I have a sneaking suspicion that the hwnd there is actually OpenConsole.exe (though, I guess that would have the old conhost icon, not the Terminal one...).

I'm not sure how I can check that. That pill disappears when alt+tabbing back to WT or clicking on the icon when restarting explorer - so they are related.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 1, 2024
@zadjii-msft
Copy link
Member

Okay maybe we need to take a step back here - why are you killing explorer? Is there like, a reason you're trying to run without it? I'm pretty confident that running with explorer killed is largely an unsupported scenario, so like... Here be dragons 🐉/?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 7, 2024
@mybearworld
Copy link
Author

If explorer is unable to start for whatever reason, using the console to restart explorer/run some checks/whatever is probably not an unlikely scenario.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Feb 12, 2024
@tusharsnx
Copy link
Contributor

tusharsnx commented Feb 13, 2024

Right click to the rescue!

no-explorer-wt-maximize.mp4

For why the buttons don't work... maybe there's a WinUI overlay that we are drawing on top of system caption buttons which is stealing all the mouse events 🤔 Since right click gets you the same functionality, I don't think we need any special arrangement for a no-explorer case.

@carlos-zamora carlos-zamora added the Priority-3 A description (P3) label Feb 14, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Feb 14, 2024
@carlos-zamora carlos-zamora removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 14, 2024
@carlos-zamora
Copy link
Member

Does this repro with console host?

@mybearworld
Copy link
Author

Does this repro with console host?

No, it works as expected with conhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3)
Projects
None yet
Development

No branches or pull requests

4 participants