Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard to view the top right icons when Mica is enabled #15434

Open
scott-xu opened this issue May 25, 2023 · 5 comments
Open

hard to view the top right icons when Mica is enabled #15434

scott-xu opened this issue May 25, 2023 · 5 comments
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@scott-xu
Copy link

Windows Terminal version

1.17.11391

Windows build number

10.0.22621.1778

Other Software

No response

Steps to reproduce

Create a custom theme and enable Mica:

        {
            "name": "Mica",
            "tab": 
            {
                "background": null,
                "showCloseButton": "always",
                "unfocusedBackground": null
            },
            "tabRow": 
            {
                "background": "#00000000",
                "unfocusedBackground": null
            },
            "window": 
            {
                "applicationTheme": "system",
                "useMica": true
            }
        }

Expected Behavior

No response

Actual Behavior

image

@scott-xu scott-xu added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 25, 2023
@zadjii-msft
Copy link
Member

What is your OS theme set to? Light presumably?

I bet we're assuming that #00000000 is basically just #000000 and then picking the white foregrounds for those buttons, when the color will actually be light. Yikes.

I bet you could work around this with

            "tabRow": 
            {
                "background": "#ffffff00",
                "unfocusedBackground": null
            },

to trick the terminal into thinking that the color of the tab row will be #ffffff, and thereby chosing the dark foregrounds.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Theming Anything related to the theming of elements of the window labels May 25, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone May 25, 2023
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 25, 2023
@scott-xu
Copy link
Author

"background": "#ffffff00" fixes the issue. The release notes of 1.17.1023 needs to update.

@scott-xu
Copy link
Author

image

@DanielRouxSA
Copy link

DanielRouxSA commented Aug 21, 2023

I just tested the workaround of setting the background to #ffffff00, but I find this does not actually fix the issue; it merely inverts the problem - the button icons are now correctly dark in light mode, but remain dark when dark mode is enabled, again making them almost impossible to see.

@electronic-dk
Copy link

Can confirm this has been an issue since the release of mica - icons are hardly legible when the terminal is in light mode. I assume the icon color selection logic when using mica should be the same as with "Use Windows theme".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants