[1.17] Dark titlebar in light theme

[angelog0]

Windows Terminal version

1.17.1023

Windows build number

10.0.19045.2546

Other Software

No response

Steps to reproduce

Start WT. it shows up as in the attachment, i.e. with a black background in the window title bar

Expected Behavior

After I click on another window app or on the Desktop it shows up as in the attachment which I would expect and prefer , i.e. with a white background in the window title bar. Notice WT does not return to look as in the first start above (black background in window title bar)

Actual Behavior

See above.

[DHowett]

Would you mind sharing your settings.json?

[angelog0]

Now attached.

wt-settings.tar.gz

[angelog0]

BTW, I had (just now uninstalled) WT-1.15 (no-preview) and it had changed my settings.json removing ALL my comments and adding some other stuff SILENTLY. Luckily I have a backup of that file... I often leave as comment old configurations and alternative to statements and references to WEB and other docs where I find suggestions etc..

[zadjii-msft]

@angelog0 Thet's tracked in #8991

[zadjii-msft]

        {
            "name": "system2",
            "window": {
                "applicationTheme": "system"
            },
            "tab": {
                "background": "terminalBackground",
                "showCloseButton": "hover",
                "unfocusedBackground": "#00000000"
            }
        },

I'd reckon this is due to your OS being in dark theme, the Terminal being in system, and us finally obeying the app theme when it comes to the titlebar (#14536).

If you change system to light in your theme, is that more what you're looking for/?

[angelog0]

@zadjii-msft I tried this:

{
            "name": "system2",
            "window": {
                "applicationTheme": "light"
            },
            "tab": {
                "background": "terminalBackground",
                "showCloseButton": "hover",
                "unfocusedBackground": "#00000000"
            }
        },

but it does not work: same result...

[zadjii-msft]

10.0.19045.2546

Hmmmmmmm the API we use to change the titlebar color might not exist in Windows 10. Any chance you've got a Windows 11 machine you could test with?

[zadjii-msft]

DWMWA_USE_IMMERSIVE_DARK_MODE
Use with DwmSetWindowAttribute. Allows the window frame for this window to be drawn in dark mode colors when the dark mode system setting is enabled. For compatibility reasons, all windows default to light mode regardless of the system setting. The pvAttribute parameter points to a value of type BOOL. TRUE to honor dark mode for the window, FALSE to always use light mode.

This value is supported starting with Windows 11 Build 22000.

emph. added

I think I'm gonna have to call this one by-design. I can't repro this with your theme on Win11, and it looks like that API is only officially supported on Win 11.

[DHowett]

Your comment about the system requirements of Windows 11 and the size of our heads IS off-topic, @angelog0. The topic of this issue is the titlebar color, and the topic of this repository is the Windows Terminal and Windows Console Host. If you want a forum in which to air your grievances about things that are not Windows Terminal, the Windows Console Host, or the titlebar color of Windows Terminal or the Windows Console Host I will gladly redirect you to Reddit.

[DHowett]

(This change you're asking about actually isn't version-specific. Your tab row is set to light theme, which suggests that your application is set to light theme. I think we should offer title bar customization alongside tab row customization probably. We found that out while triaging a later issue than this one.)