Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marks on scrollbar: Highlight mark on scrollToMark #13455

Open
zadjii-msft opened this issue Jul 7, 2022 · 0 comments
Open

Marks on scrollbar: Highlight mark on scrollToMark #13455

zadjii-msft opened this issue Jul 7, 2022 · 0 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Unfortunately, the navigation isn't very smart yet. When jumping to the previous/next mark, the window area merely scrolls such that the marked line becomes visible.

It would be much nicer if

  • the line was highlighted (briefly) after the navigation action – this would make it easy to immediately find the marked line visually.
    A temporary highlight effect should be used to visually guide the user to the target line.

How do we reconcile this with FTCS style marks, with a prompt/command/output section? Do we select just the prompt? The command? The whole blob?

What about for multiline marks?

  • crawl: a rect with just from the start->end points of the mark, regardless of how ridiculous that looks
  • walk: a bunch of rects for each line
  • run: rects for each line, with intelligent borders so the border is only around the actual marked text

originally posted by @jkuebart in #13449
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 7, 2022
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 7, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 7, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 7, 2022
Open
37 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 7, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@zadjii-msft