Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Copy without dismissing selection #13438

Closed
zadjii-msft opened this issue Jul 5, 2022 · 3 comments
Closed

Suggestion: Copy without dismissing selection #13438

zadjii-msft opened this issue Jul 5, 2022 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Suggestion/question: in ConEmu mark mode ctrl+c/copy keybinding copies only but Enter copies and exits mark mode. Is that how ours works?

Originally posted by @ofek in #13369 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 5, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. good first issue This is a fix that might be easier for someone to do as a first contribution and removed Needs-Tag-Fix Doesn't match tag requirements labels Jul 5, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 5, 2022
@zadjii-msft
Copy link
Member Author

I coulda swore this was on the backlog, but couldn't find it. I've been wrong before.

Should be fairly trivial to add a dismissSelection property to the copy action, defaults to true, and does what you'd expect. We should then change the enter keybinding to

        { "command": { "action": "copy", "singleLine": false, "dismissSelection": false }, "keys": "enter" },

er... maybe we don't change the defaults. Those would be the opposite of ConEmu

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 5, 2022
Closed
@carlos-zamora
Copy link
Member

Found it! You were looking for #3884

/dup #3884

@ghost
Copy link

ghost commented Jul 5, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jul 5, 2022
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jul 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 6, 2022
Open
@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2022
Merged
2 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@carlos-zamora @zadjii-msft