Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to do the window owner thing for WPF too #12911

Open
zadjii-msft opened this issue Apr 15, 2022 · 1 comment
Open

Make sure to do the window owner thing for WPF too #12911

zadjii-msft opened this issue Apr 15, 2022 · 1 comment
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Our friends at VS would like to remind us to port the #2988, #12526, #12799, #12899, #12900 series of fixes to the WPF control as well as the WinUI one.
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Area-WPFControl Things related to the WPF version of the TermControl labels Apr 15, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone Apr 15, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 15, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 15, 2022
@zadjii-msft
Copy link
Member Author

My WIP branch was in dev/migrie/b/12911-wpf-focus-fg. We'll probably need to work specifically with VS to get this hooked up.

We may want to just ship a Terminal.Connection.nuget so they can just use the conpty connection we implement.

We almost definitely want to get WPF off of the HWND core and onto the ControlCore.

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H1 Apr 28, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Backlog Aug 3, 2022
@german-one german-one mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@zadjii-msft