Skip to content

[Terminal]: 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Settings page. #12424

Open
@ghost

Description

Windows Terminal version

1.13.10336.0

Windows build number

10.0.22543.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22543.1000)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Observe the issue.

User Experience:
Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Save' and 'Discard' as result they will not be able to figure out whether these buttons are actionable or not.

Attachments:
'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes..zip

Expected Behavior

'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Setting page.

Actual Behavior

'Save' and 'Discard Changes' buttons are in active state even if they are not actionable inside Setting page.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A11yCOAccessibility trackingA11yUsableAccessibility trackingArea-AccessibilityIssues related to accessibilityArea-SettingsUIAnything specific to the SUIHCL-E+DAccessibility trackingHCL-WindowsTerminalAccessibility trackingIssue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Priority-3A description (P3)Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions