profile-icons with web sources are not shown on the taskbar

[torgeros]

Windows Terminal version (or Windows build number)

1.8.1521.0

Other Software

No response

Steps to reproduce

I am using WINDOWS 11, I do not know how this behaves in Win10.

1. Create a new profile (or use an existing one)
2. For the icon, paste a weblink to an ico file (eg https://github.com/favicon.ico)
3. As you will see, that works fine (the icon gets shown in new tabs and in the settings menu)
   
4. keep winterm open
5. right-click onto the program in the taskbar
6. As you will see, the icons are not rendered here
   

Expected Behavior

Profile Icons are rendered the same way everywhere across the device

Actual Behavior

Profile Icons from the web are not rendered at all in the taskbar dialog

[zadjii-msft]

You know, I am confident that we have a dupe for this floating around on the repo, but I can't find it. The same thing happens when using an emoji as the icon for a profile.

I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.

[torgeros]

I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.

I someone is going to implement that, maybe also make copies of local images to an app-internal path. I found it somewhat annoying that I have to make sure that my custom local icons do not get deleted by accident.

Like for example when I download an image, set it as profile icon, and then clean up my downloads folder, the profile icon is gone.

[DHowett]

Yeah -- we should cache local and remote paths, honestly. We need to be extra careful to not cache old copies of local icons that have changed, but that should present little issue.

Technically -- and unrelatedly, mind you -- we should also be caching them in memory. Reloading every image every time the settings changes is a right pain. 😄