Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the TabView span the entire window width #10320

Closed
ghost opened this issue Jun 3, 2021 · 4 comments
Closed

Make the TabView span the entire window width #10320

ghost opened this issue Jun 3, 2021 · 4 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@ghost
Copy link

ghost commented Jun 3, 2021

Description of the new feature/enhancement

The TabView currently stops after the add button. This is a problem because it has a shadow which gets interrupted.
It's harder to see with the default gray titlebar, but if you could change it to white it would be noticeable.

It would be ideal if the TabView would span the entire window.

tabviewcurrent
tabviewfixed

Proposed technical implementation details

It can be achieved by moving the drag bar and caption buttons inside the TabStripFooter.

@ghost ghost added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 3, 2021
@zadjii-msft
Copy link
Member

So this is a cool idea, but also fraught with peril. We're doing all sorts of wonky Win32 hacks to let the user drag that region as it is. I'd love to have the shadow work across that entire region, but we'll need to be careful to not break that behavior.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 6, 2021
@zadjii-msft zadjii-msft added this to the Console Backlog milestone Jul 6, 2021
@zadjii-msft zadjii-msft removed the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 6, 2021
@orcmid
Copy link

orcmid commented Jul 6, 2021

@zadjii-msft > ... let the user drag that region

Yes, I have already become seriously frustrated by applications that shrink the draggable part of the title bar because of other cruft piling up there. (I confess that I have become fond of Edge's shrinkiable vertical tabs and how it leaves a wide title bar with the title of the tab for the current focus.)

@DHowett
Copy link
Member

DHowett commented Jul 6, 2021

Yep -- if we do this, we'll need to make sure that AppHost can still communicate with NonClientIslandWindow to let it know where the draggable region is.

We used to do this because we had to punch a hole in the XAML window where no content could be displayed -- now it's just an implementation of convenience (read: software engineering is lazy and optimizes around local maxima sometimes 😁) since we have a different drag bar implementation. 😄

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 6, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft
Copy link
Member

Oh hey we did this in #12916

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants