Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italics look awkward and are hard to read (possibly different font entirely?) #10231

Closed
Tracked by #1790
faho opened this issue May 27, 2021 · 7 comments
Closed
Tracked by #1790
Labels
Area-Fonts Related to the font Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Resolution-External For issues that are outside this codebase

Comments

@faho
Copy link

faho commented May 27, 2021

Windows Terminal version (or Windows build number)

1.9.1445.0

Other Software

In this case Debian 10 in WSL1, bash 5.0.3, ncurses 6.1+20181013-2+deb10u2

I don't think it matters.

Steps to reproduce

Set font to Cascadia Code or Mono (which, as I understand it, is the default and recommended font?)

Inside bash (or fish) run:

printf '\e[3mitalic\n\e(B\e[mnormal\n'

This shows the a line with the text "italic" in italic, and a line that says "normal" in non-italic.

(\e[3m is xterm's "enter_italics_mode" and \e(B\e[m is exit_attribute_mode)

Expected Behavior

Italic font is essentially the same as the normal font and readable.

Actual Behavior

Italic font is distracting and hard to read.

screenshot

This is mainly an issue for me because my emacs configuration renders comments in italic, so it's hard to read the comments.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 27, 2021
@skyline75489
Copy link
Collaborator

Actually this is expected. The font is called 'Cascadia "Curve"'. See https://github.com/microsoft/cascadia-code/releases/tag/v2105.24

@faho
Copy link
Author

faho commented May 27, 2021

... is there a way to turn it off?

I legitimately find it distracting (because it's sooo different from the rest) and hard to read.

Cascadia itself is alright and the other fonts I have installed are bad, so I would prefer not to have to switch to something else entirely.

E.g.

2021-05-27 13_03_00-emacs app py

This reads to me as "Default optionj ane manked with *"

(also already reported for cascadia-code at microsoft/cascadia-code#468)

@zadjii-msft
Copy link
Member

You know, we've got issues for "add setting to disable xyz font feature", so it's not unreasonable to have one for italics as well. I'll tag this up and include it in #1790

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels May 27, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 27, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 27, 2021
@DHowett
Copy link
Member

DHowett commented May 27, 2021

I'm going to say that we should subsume this issue ("disable italics") into the font config one, close this one and direct users who have complaints about Cascadia to move along to the Cascadia repository.

@DHowett
Copy link
Member

DHowett commented May 27, 2021

So: if you have complaints about Cascadia, move along to the cascadia repository.

@DHowett DHowett closed this as completed May 27, 2021
@DHowett DHowett added Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Resolution-External For issues that are outside this codebase labels May 27, 2021
@Uxorious
Copy link

Sure. But in the meantime, I suspect a lot of us will stop using Cascadia Code.

@DHowett
Copy link
Member

DHowett commented May 27, 2021

You're welcome to do that.

@microsoft microsoft locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area-Fonts Related to the font Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

5 participants