Skip to content

Commit e7df7d0

Browse files
committed
add a sample for @carlos-zamora, and make it clearer
1 parent d9dba62 commit e7df7d0

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

doc/specs/#6899 - Action IDs/#6899 - Action IDs.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,15 @@ doesn't _need_ to define any actions in `actions` - they could solely define
5555
actions in the bindings.
5656

5757
**TODO**: When parsing a binding with both an `id` and a `command`, should we
58-
use the action from the ID or the command? Both seem reasonable.
58+
use the action from the ID or the command? Both seem reasonable. e.g:
59+
60+
```json
61+
"bindings":[
62+
{ "command": { "action": "newTab", "profile": "foo" }, "id": "MyAction" }
63+
]
64+
```
65+
Should we use the `MyAction` command, or the manually specified one?
66+
5967

6068
Keybindings will still be stored as a `keys->Action` mapping, so the user will
6169
still be able to override default keybindings exactly the same as before.
@@ -130,8 +138,9 @@ provided, enabling the user to re-use their existing definitions. If the user
130138
re-defined the `Terminal.IncreaseFontSize` action to mean something else, then
131139
the action in the new tab menu will also be automatically updated.
132140

133-
Furthermore, when additional menus are added, these could also leverage a
134-
similar syntax to the above to allow re-use of the `id` parameter.
141+
Furthermore, when additional menus are added (such as the tab context menu, or
142+
the `TermControl` context menu), these could also leverage a similar syntax to
143+
the above to allow re-use of the `id` parameter.
135144

136145
## UI/UX Design
137146

0 commit comments

Comments
 (0)