Skip to content

Commit da5ec7b

Browse files
PankajBhojwaniDHowett
authored andcommitted
Always show the bell indicator when BEL is emitted (#9212)
Regardless of whether the bellstyle is set to visual, show the bell indicator in the tab header (cherry picked from commit d12a71c)
1 parent ba534aa commit da5ec7b

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

src/cascadia/TerminalApp/TerminalTab.cpp

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -709,25 +709,26 @@ namespace winrt::TerminalApp::implementation
709709
}
710710
});
711711

712-
// Add a PaneRaiseVisualBell event handler to the Pane. When the pane emits this event,
713-
// we need to bubble it all the way to app host. In this part of the chain we bubble it
714-
// from the hosting tab to the page.
712+
// Add a PaneRaiseBell event handler to the Pane
715713
pane->PaneRaiseBell([weakThis](auto&& /*s*/, auto&& visual) {
716714
if (auto tab{ weakThis.get() })
717715
{
718716
if (visual)
719717
{
718+
// If visual is set, we need to bubble this event all the way to app host to flash the taskbar
719+
// In this part of the chain we bubble it from the hosting tab to the page
720720
tab->_TabRaiseVisualBellHandlers();
721+
}
721722

722-
tab->ShowBellIndicator(true);
723+
// Show the bell indicator in the tab header
724+
tab->ShowBellIndicator(true);
723725

724-
// If this tab is focused, activate the bell indicator timer, which will
725-
// remove the bell indicator once it fires
726-
// (otherwise, the indicator is removed when the tab gets focus)
727-
if (tab->_focusState != WUX::FocusState::Unfocused)
728-
{
729-
tab->ActivateBellIndicatorTimer();
730-
}
726+
// If this tab is focused, activate the bell indicator timer, which will
727+
// remove the bell indicator once it fires
728+
// (otherwise, the indicator is removed when the tab gets focus)
729+
if (tab->_focusState != WUX::FocusState::Unfocused)
730+
{
731+
tab->ActivateBellIndicatorTimer();
731732
}
732733
}
733734
});

0 commit comments

Comments
 (0)