From 19b6d351a53589dcefe926bcc02adaef308789e4 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Mon, 29 Aug 2022 16:38:02 -0500 Subject: [PATCH] Remove the `useMica` key (#13872) It's not making it for 1.16, so it's out. Closes a bullet point in #13725 --- .../LocalTests_SettingsModel/ThemeTests.cpp | 16 +++++----------- .../TerminalSettingsModel/MTSMSettings.h | 5 ++--- src/cascadia/TerminalSettingsModel/Theme.idl | 1 - 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp b/src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp index 4e3bdacc254..327be5ad92c 100644 --- a/src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp +++ b/src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp @@ -64,8 +64,7 @@ namespace SettingsModelLocalTests }, "window": { - "applicationTheme": "light", - "useMica": true + "applicationTheme": "light" } })" }; @@ -81,7 +80,6 @@ namespace SettingsModelLocalTests VERIFY_IS_NOT_NULL(theme->Window()); VERIFY_ARE_EQUAL(winrt::Windows::UI::Xaml::ElementTheme::Light, theme->Window().RequestedTheme()); - VERIFY_ARE_EQUAL(true, theme->Window().UseMica()); } void ThemeTests::ParseEmptyTheme() @@ -163,8 +161,7 @@ namespace SettingsModelLocalTests }, "window": { - "applicationTheme": "light", - "useMica": true + "applicationTheme": "light" } }, { @@ -175,16 +172,14 @@ namespace SettingsModelLocalTests }, "window": { - "applicationTheme": "light", - "useMica": true + "applicationTheme": "light" } }, { "name": "backgroundOmittedEntirely", "window": { - "applicationTheme": "light", - "useMica": true + "applicationTheme": "light" } } ] @@ -239,8 +234,7 @@ namespace SettingsModelLocalTests "tabRow": {}, "window": { - "applicationTheme": "light", - "useMica": true + "applicationTheme": "light" } } ] diff --git a/src/cascadia/TerminalSettingsModel/MTSMSettings.h b/src/cascadia/TerminalSettingsModel/MTSMSettings.h index b6dcf7e37c6..4ebc362ddd6 100644 --- a/src/cascadia/TerminalSettingsModel/MTSMSettings.h +++ b/src/cascadia/TerminalSettingsModel/MTSMSettings.h @@ -122,9 +122,8 @@ Author(s): X(winrt::Microsoft::Terminal::Settings::Model::TabRowTheme, TabRow, "tabRow", nullptr) \ X(winrt::Microsoft::Terminal::Settings::Model::TabTheme, Tab, "tab", nullptr) -#define MTSM_THEME_WINDOW_SETTINGS(X) \ - X(winrt::Windows::UI::Xaml::ElementTheme, RequestedTheme, "applicationTheme", winrt::Windows::UI::Xaml::ElementTheme::Default) \ - X(bool, UseMica, "useMica", false) +#define MTSM_THEME_WINDOW_SETTINGS(X) \ + X(winrt::Windows::UI::Xaml::ElementTheme, RequestedTheme, "applicationTheme", winrt::Windows::UI::Xaml::ElementTheme::Default) #define MTSM_THEME_TABROW_SETTINGS(X) \ X(winrt::Microsoft::Terminal::Settings::Model::ThemeColor, Background, "background", nullptr) \ diff --git a/src/cascadia/TerminalSettingsModel/Theme.idl b/src/cascadia/TerminalSettingsModel/Theme.idl index 3dd2782c48e..32127abf2ce 100644 --- a/src/cascadia/TerminalSettingsModel/Theme.idl +++ b/src/cascadia/TerminalSettingsModel/Theme.idl @@ -36,7 +36,6 @@ namespace Microsoft.Terminal.Settings.Model runtimeclass WindowTheme { Windows.UI.Xaml.ElementTheme RequestedTheme { get; }; - Boolean UseMica { get; }; } runtimeclass TabRowTheme {