-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Switch from API keys to Azure Credentials when accessing Azure Cognitive Services #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation and Context Switch to using DefaultAzureCredential and get all tests passing locally See: #6966 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
documentation
labels
Sep 4, 2024
RogerBarreto
approved these changes
Sep 4, 2024
### Motivation and Context Adding a step to perform an Azure Login, this will be used by the integration tests to access Azure Cognitive Services ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
### Motivation and Context Give write permissions to id-token in the workflow ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
### Motivation and Context Update MixedAgentTests to use a token credential ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
### Motivation and Context `DefaultAzureCredential` attempts multiple strategies but we can start by just relying on Azure Cli login. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
SergeyMenshykh
approved these changes
Sep 10, 2024
RogerBarreto
approved these changes
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
markwallace-microsoft
had a problem deploying
to
integration
September 10, 2024 13:52
— with
GitHub Actions
Failure
markwallace-microsoft
had a problem deploying
to
integration
September 10, 2024 13:52
— with
GitHub Actions
Failure
markwallace-microsoft
had a problem deploying
to
integration
September 10, 2024 13:52
— with
GitHub Actions
Failure
markwallace-microsoft
had a problem deploying
to
integration
September 10, 2024 13:57
— with
GitHub Actions
Failure
markwallace-microsoft
temporarily deployed
to
integration
September 10, 2024 14:06
— with
GitHub Actions
Inactive
markwallace-microsoft
temporarily deployed
to
integration
September 10, 2024 14:49
— with
GitHub Actions
Inactive
markwallace-microsoft
temporarily deployed
to
integration
September 10, 2024 15:09
— with
GitHub Actions
Inactive
markwallace-microsoft
temporarily deployed
to
integration
September 10, 2024 15:47
— with
GitHub Actions
Inactive
SergeyMenshykh
approved these changes
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes: #6966