Add CultureInfo to SKContext #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The culture defaults to CurrentCulture but can be explicitly set to change it. Native functions can declare a CultureInfo or IFormatProvider argument, and the culture from the context will implicitly flow as the value of that argument, such that functions can then naturally use it for culture-related customization. The culture from the context is also used for all implicit parsing / formatting operations performed as part of function invocation.
github-actions
bot
added
.NET
shawncal
approved these changes
Jun 20, 2023
yoshioterada
pushed a commit
to yoshioterada/semantic-kernel
that referenced
this pull request
Jun 21, 2023
### Motivation and Context Enable callers to configure culture information that flows into native functions and that controls how implicit parsing / formatting is performed. microsoft#1226 microsoft#1374 ### Description The culture defaults to CurrentCulture but can be explicitly set to change it. Native functions can declare a CultureInfo or IFormatProvider argument, and the culture from the context will implicitly flow as the value of that argument, such that functions can then naturally use it for culture-related customization. The culture from the context is also used for all implicit parsing / formatting operations performed as part of function invocation. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context Enable callers to configure culture information that flows into native functions and that controls how implicit parsing / formatting is performed. microsoft#1226 microsoft#1374 ### Description The culture defaults to CurrentCulture but can be explicitly set to change it. Native functions can declare a CultureInfo or IFormatProvider argument, and the culture from the context will implicitly flow as the value of that argument, such that functions can then naturally use it for culture-related customization. The culture from the context is also used for all implicit parsing / formatting operations performed as part of function invocation. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Enable callers to configure culture information that flows into native functions and that controls how implicit parsing / formatting is performed.
#1226
#1374
Description
The culture defaults to CurrentCulture but can be explicitly set to change it. Native functions can declare a CultureInfo or IFormatProvider argument, and the culture from the context will implicitly flow as the value of that argument, such that functions can then naturally use it for culture-related customization. The culture from the context is also used for all implicit parsing / formatting operations performed as part of function invocation.
Contribution Checklist
dotnet format