.Net: Updated chat history reducers to include system message #10344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
dmytrostruk
had a problem deploying
to
integration
GitHub Actions
Failure
dmytrostruk
had a problem deploying
to
integration
GitHub Actions
Error
dmytrostruk
had a problem deploying
to
integration
GitHub Actions
Error
dmytrostruk
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Jan 30, 2025
dotnet/src/SemanticKernel.Core/AI/ChatCompletion/ChatHistoryReducerExtensions.cs
Show resolved
Hide resolved
westey-m
reviewed
Jan 30, 2025
dotnet/src/SemanticKernel.Core/AI/ChatCompletion/ChatHistorySummarizationReducer.cs
Show resolved
Hide resolved
westey-m
reviewed
Jan 30, 2025
dotnet/src/SemanticKernel.UnitTests/AI/ChatCompletion/ChatHistorySummarizationReducerTests.cs
Show resolved
Hide resolved
dmytrostruk
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Related: #10102
This PR contains changes to the chat history reducer implementations to avoid redaction of system messages if they exist in chat history. It's important to keep system messages in the chat history so the model can follow initial instructions independently from history redaction.
Contribution Checklist