Extract default sass plugin from heft to its own heft-sass-plugin

Author: jonasb

apps/heft/package.json

@@ -42,9 +42,6 @@
     "fast-glob": "~3.2.4",
     "glob": "~7.0.5",
     "glob-escape": "~0.0.2",
-    "node-sass": "5.0.0",
-    "postcss": "7.0.32",
-    "postcss-modules": "~1.5.0",
     "prettier": "~2.3.0",
     "semver": "~7.3.0",
     "tapable": "1.1.3",
@@ -60,7 +57,6 @@
     "@types/glob": "7.1.1",
     "@types/heft-jest": "1.0.1",
     "@types/node": "10.17.13",
-    "@types/node-sass": "4.11.1",
     "@types/semver": "7.3.5",
     "colors": "~1.2.1",
     "tslint": "~5.20.1",

apps/heft/src/pluginFramework/PluginManager.ts

@@ -20,7 +20,6 @@ import { DeleteGlobsPlugin } from '../plugins/DeleteGlobsPlugin';
 import { CopyStaticAssetsPlugin } from '../plugins/CopyStaticAssetsPlugin';
 import { RunScriptPlugin } from '../plugins/RunScriptPlugin';
 import { ApiExtractorPlugin } from '../plugins/ApiExtractorPlugin/ApiExtractorPlugin';
-import { SassTypingsPlugin } from '../plugins/SassTypingsPlugin/SassTypingsPlugin';
 import { ProjectValidatorPlugin } from '../plugins/ProjectValidatorPlugin';
 import { ToolPackageResolver } from '../utilities/ToolPackageResolver';
 import { NodeServicePlugin } from '../plugins/NodeServicePlugin';
@@ -53,7 +52,6 @@ export class PluginManager {
     this._applyPlugin(new DeleteGlobsPlugin());
     this._applyPlugin(new RunScriptPlugin());
     this._applyPlugin(new ApiExtractorPlugin(taskPackageResolver));
-    this._applyPlugin(new SassTypingsPlugin());
     this._applyPlugin(new ProjectValidatorPlugin());
     this._applyPlugin(new NodeServicePlugin());
   }

apps/heft/src/templates/sass.json

@@ -13,7 +13,6 @@ import { IApiExtractorPluginConfiguration } from '../plugins/ApiExtractorPlugin/
 import { ITypeScriptConfigurationJson } from '../plugins/TypeScriptPlugin/TypeScriptPlugin';
 import { HeftConfiguration } from '../configuration/HeftConfiguration';
 import { Terminal } from '@rushstack/node-core-library';
-import { ISassConfigurationJson } from '../plugins/SassTypingsPlugin/SassTypingsPlugin';
 import { INodeServicePluginConfiguration } from '../plugins/NodeServicePlugin';
 
 export enum HeftEvent {
@@ -125,7 +124,6 @@ export class CoreConfigFiles {
   private static _nodeServiceConfigurationLoader:
     | ConfigurationFile<INodeServicePluginConfiguration>
     | undefined;
-  private static _sassConfigurationFileLoader: ConfigurationFile<ISassConfigurationJson> | undefined;
 
   /**
    * Returns the loader for the `config/heft.json` config file.
@@ -283,27 +281,6 @@ export class CoreConfigFiles {
     return CoreConfigFiles._nodeServiceConfigurationLoader;
   }
 
-  public static get sassConfigurationFileLoader(): ConfigurationFile<ISassConfigurationJson> {
-    const schemaPath: string = path.resolve(__dirname, '..', 'schemas', 'sass.schema.json');
-    CoreConfigFiles._sassConfigurationFileLoader = new ConfigurationFile<ISassConfigurationJson>({
-      projectRelativeFilePath: 'config/sass.json',
-      jsonSchemaPath: schemaPath,
-      jsonPathMetadata: {
-        '$.importIncludePaths.*': {
-          pathResolutionMethod: PathResolutionMethod.resolvePathRelativeToProjectRoot
-        },
-        '$.generatedTsFolder.*': {
-          pathResolutionMethod: PathResolutionMethod.resolvePathRelativeToProjectRoot
-        },
-        '$.srcFolder.*': {
-          pathResolutionMethod: PathResolutionMethod.resolvePathRelativeToProjectRoot
-        }
-      }
-    });
-
-    return CoreConfigFiles._sassConfigurationFileLoader;
-  }
-
   private static _addEventActionToMap<TEventAction extends IHeftConfigurationJsonEventActionBase>(
     eventAction: TEventAction,
     map: Map<HeftEvent, TEventAction[]>

apps/heft/src/utilities/CoreConfigFiles.ts

@@ -5,5 +5,5 @@
     "typeRoots": ["./custom-typings", "./node_modules/@types/"],
     "types": ["heft-jest", "node"]
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "./custom-typings/**/*.ts"]
+  "include": ["src/**/*.ts", "src/**/*.tsx"]
 }

apps/heft/tsconfig.json

@@ -52,6 +52,12 @@
        * The path to the plugin package.
        */
       "plugin": "@rushstack/heft-jest-plugin"
+    },
+    {
+      /**
+       * The path to the plugin package.
+       */
+      "plugin": "@rushstack/heft-sass-plugin"
     }
   ]
 }

build-tests/heft-sass-test/config/heft.json

@@ -11,6 +11,7 @@
     "@rushstack/eslint-config": "workspace:*",
     "@rushstack/heft": "workspace:*",
     "@rushstack/heft-jest-plugin": "workspace:*",
+    "@rushstack/heft-sass-plugin": "workspace:*",
     "@rushstack/heft-webpack4-plugin": "workspace:*",
     "@types/heft-jest": "1.0.1",
     "@types/react-dom": "16.9.8",

build-tests/heft-sass-test/package.json

@@ -2,6 +2,10 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/rush/v5/approved-packages.schema.json",
   "packages": [
+    {
+      "name": "@rushstack/heft-sass-plugin",
+      "allowedCategories": [ "tests" ]
+    },
     {
       "name": "react",
       "allowedCategories": [ "tests" ]

common/config/rush/browser-approved-packages.json

@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "f45464cdd2ef1f79ab3446b3edd2384175b1e967",
+  "pnpmShrinkwrapHash": "90d9a6f48b14750485b141fc7547965bcb69bb9f",
   "preferredVersionsHash": "1fbc26d2c5b3248616b9edccd6bef064075243bc"
 }