Skip to content

Commit 7e14cda

Browse files
authored
fix: remove "import" entries from exports in package.json files (#5650)
The "import" condition in "exports" maps was added in 6d669f1, but it breaks scenarios where the lib-esm/ output doesn't exist or has incompatibilities. Remove all "import" entries from 78 published project package.json files to fix issue #5644.
1 parent 2c085cf commit 7e14cda

File tree

160 files changed

+1045
-71
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

160 files changed

+1045
-71
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ These GitHub repositories provide supplementary resources for Rush Stack:
182182
| [/build-tests/eslint-bulk-suppressions-test](./build-tests/eslint-bulk-suppressions-test/) | Sample code to test eslint bulk suppressions |
183183
| [/build-tests/eslint-bulk-suppressions-test-flat](./build-tests/eslint-bulk-suppressions-test-flat/) | Sample code to test eslint bulk suppressions with flat configs |
184184
| [/build-tests/eslint-bulk-suppressions-test-legacy](./build-tests/eslint-bulk-suppressions-test-legacy/) | Sample code to test eslint bulk suppressions for versions of eslint < 8.57.0 |
185+
| [/build-tests/esm-node-import-test](./build-tests/esm-node-import-test/) | This project validates that importing a rushstack package from a 'type: module' Node.js project works correctly with the package.json 'exports' field. See https://github.com/microsoft/rushstack/issues/5644 |
185186
| [/build-tests/hashed-folder-copy-plugin-webpack5-test](./build-tests/hashed-folder-copy-plugin-webpack5-test/) | Building this project exercises @rushstack/hashed-folder-copy-plugin with Webpack 5. NOTE - THIS TEST IS CURRENTLY EXPECTED TO BE BROKEN |
186187
| [/build-tests/heft-copy-files-test](./build-tests/heft-copy-files-test/) | Building this project tests copying files with Heft |
187188
| [/build-tests/heft-example-lifecycle-plugin](./build-tests/heft-example-lifecycle-plugin/) | This is an example heft plugin for testing the lifecycle hooks |

apps/api-documenter/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@
2323
"exports": {
2424
".": {
2525
"types": "./dist/rollup.d.ts",
26+
"node": "./lib-commonjs/index.js",
2627
"import": "./lib-esm/index.js",
2728
"require": "./lib-commonjs/index.js"
2829
},
2930
"./lib/*.schema.json": "./lib-commonjs/*.schema.json",
3031
"./lib/*": {
3132
"types": "./lib-dts/*.d.ts",
33+
"node": "./lib-commonjs/*.js",
3234
"import": "./lib-esm/*.js",
3335
"require": "./lib-commonjs/*.js"
3436
},

apps/api-extractor/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,14 @@
3131
"exports": {
3232
".": {
3333
"types": "./dist/rollup.d.ts",
34+
"node": "./lib-commonjs/index.js",
3435
"import": "./lib-esm/index.js",
3536
"require": "./lib-commonjs/index.js"
3637
},
3738
"./lib/*.schema.json": "./lib-commonjs/*.schema.json",
3839
"./lib/*": {
3940
"types": "./lib-dts/*.d.ts",
41+
"node": "./lib-commonjs/*.js",
4042
"import": "./lib-esm/*.js",
4143
"require": "./lib-commonjs/*.js"
4244
},

apps/cpu-profile-summarizer/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"exports": {
3030
"./lib/*": {
3131
"types": "./lib-dts/*.d.ts",
32+
"node": "./lib-commonjs/*.js",
3233
"import": "./lib-esm/*.js",
3334
"require": "./lib-commonjs/*.js"
3435
},

apps/heft/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,14 @@
2727
"exports": {
2828
".": {
2929
"types": "./dist/heft.d.ts",
30+
"node": "./lib-commonjs/index.js",
3031
"import": "./lib-esm/index.js",
3132
"require": "./lib-commonjs/index.js"
3233
},
3334
"./lib/*.schema.json": "./lib-commonjs/*.schema.json",
3435
"./lib/*": {
3536
"types": "./lib-dts/*.d.ts",
37+
"node": "./lib-commonjs/*.js",
3638
"import": "./lib-esm/*.js",
3739
"require": "./lib-commonjs/*.js"
3840
},

apps/lockfile-explorer/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"./lib/*.schema.json": "./lib-commonjs/*.schema.json",
7979
"./lib/*": {
8080
"types": "./lib-dts/*.d.ts",
81+
"node": "./lib-commonjs/*.js",
8182
"import": "./lib-esm/*.js",
8283
"require": "./lib-commonjs/*.js"
8384
},

apps/playwright-browser-tunnel/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@
1414
"exports": {
1515
".": {
1616
"types": "./lib-dts/index.d.ts",
17+
"node": "./lib-commonjs/index.js",
1718
"import": "./lib-esm/index.js",
1819
"require": "./lib-commonjs/index.js"
1920
},
2021
"./lib/*": {
2122
"types": "./lib-dts/*.d.ts",
23+
"node": "./lib-commonjs/*.js",
2224
"import": "./lib-esm/*.js",
2325
"require": "./lib-commonjs/*.js"
2426
},

apps/rundown/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"exports": {
3434
"./lib/*": {
3535
"types": "./lib-dts/*.d.ts",
36+
"node": "./lib-commonjs/*.js",
3637
"import": "./lib-esm/*.js",
3738
"require": "./lib-commonjs/*.js"
3839
},

apps/rush-mcp-server/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@
1515
"exports": {
1616
".": {
1717
"types": "./dist/mcp-server.d.ts",
18+
"node": "./lib-commonjs/index.js",
1819
"import": "./lib-esm/index.js",
1920
"require": "./lib-commonjs/index.js"
2021
},
2122
"./lib/*.schema.json": "./lib-commonjs/*.schema.json",
2223
"./lib/*": {
2324
"types": "./lib-dts/*.d.ts",
25+
"node": "./lib-commonjs/*.js",
2426
"import": "./lib-esm/*.js",
2527
"require": "./lib-commonjs/*.js"
2628
},

apps/rush/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"exports": {
5555
"./lib/*": {
5656
"types": "./lib-dts/*.d.ts",
57+
"node": "./lib-commonjs/*.js",
5758
"import": "./lib-esm/*.js",
5859
"require": "./lib-commonjs/*.js"
5960
},

0 commit comments

Comments
 (0)