Make ProxyHttpClientFactory public and extensible #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahbazi
reviewed
Mar 25, 2021
Kahbazi
reviewed
Apr 1, 2021
|
|
||
| Log.ProxyClientCreated(_logger, context.ClusterId); | ||
|
|
||
| return new HttpMessageInvoker(middleware, disposeHandler: true); |
There was a problem hiding this comment.
Is this HttpMessageInvoker ever get disposed?
There was a problem hiding this comment.
No, there's no way of telling when it's no longer in use, except that it will get GC'd.
Tratcher
force-pushed
the
tratcher/clientfactory
branch
from
55938b4
to
c842d03
Compare
alnikola
approved these changes
Apr 12, 2021
| @@ -52,6 +52,10 @@ public void ConfigureServices(IServiceCollection services) | |||
|
|
|||
| services.AddReverseProxy() | |||
| .LoadFromMemory(routes, clusters) | |||
| .ConfigureClient((context, handler) => | |||
| { | |||
| handler.Expect100ContinueTimeout = TimeSpan.FromMilliseconds(300); | |||
There was a problem hiding this comment.
Expect100ContinueTimeout or ConfigureClient?
- ConfigureClient this lets users change basic settings without implementing a new class.
- Expect100ContinueTimeout is only used here has an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805 Make ProxyHttpClientFactory public and extensible
Fixes #843 (@berhir) Enable adding HttpMessageHandler middleware (e.g. DelegatingHandler)
Contributes to #801 Allow using ProxyHttpClientFactory for direct IHttpProxy scenarios
ProxyHttpClientFactory is now public so people can:
A) Create it directly when using IHttpProxy
B) Derive from it to customize the SocketHttpHandler settings without completely re-implementing IProxyHttpClientFactory
C) Derive from it to enable wrapping SocketHttpHandler with DelegatingHandler middleware.
There's also a new extension for simple scenarios: