Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OutputCachePolicy support #2328

Merged
merged 12 commits into from
Nov 28, 2023
Merged

add OutputCachePolicy support #2328

merged 12 commits into from
Nov 28, 2023

Conversation

witskeeper
Copy link
Contributor

add OutputCachePolicy to RouteConfig.cs

Tratcher
Tratcher reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief description of output caching support to the docs. You can copy timeouts or RateLimiting. Also update the TOC.
https://github.com/microsoft/reverse-proxy/tree/main/docs/docfx/articles

src/ReverseProxy/Routing/ProxyEndpointFactory.cs Outdated Show resolved Hide resolved
src/Kubernetes.Controller/Converters/YarpParser.cs Show resolved Hide resolved
src/ReverseProxy/Configuration/RouteConfig.cs Show resolved Hide resolved
Tratcher
Tratcher reviewed Nov 17, 2023
View reviewed changes
docs/docfx/articles/output-caching.md Outdated Show resolved Hide resolved
docs/docfx/articles/output-caching.md Outdated Show resolved Hide resolved
witskeeper and others added 3 commits November 18, 2023 12:28
@witskeeper @Tratcher
Update docs/docfx/articles/output-caching.md
0a3673a 
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
@witskeeper @Tratcher
Update docs/docfx/articles/output-caching.md
09507a7 
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
@witskeeper
samples use the minimal APIs
2a68352
@Tratcher Tratcher enabled auto-merge (squash) November 20, 2023 18:47
Tratcher
Tratcher requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

@Tratcher Tratcher mentioned this pull request Nov 20, 2023
Merged
@witskeeper
Copy link
Contributor Author

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

i can update the Validator after #2293 merged .

@Tratcher
Copy link
Member

#2293 has been merged.

auto-merge was automatically disabled November 23, 2023 08:08

Head branch was pushed to by a user without write access

@witskeeper
Copy link
Contributor Author

witskeeper commented Nov 23, 2023 •
edited
Loading

#2293 has been merged.

done

Tratcher
Tratcher approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ReverseProxy/Configuration/IYarpOutputCachePolicyProvider.cs Outdated Show resolved Hide resolved
@witskeeper witskeeper mentioned this pull request Nov 28, 2023
Open
@Tratcher Tratcher added this to the YARP 2.x milestone Nov 28, 2023
@Tratcher Tratcher merged commit 3853af1 into microsoft:main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahbazi Kahbazi Kahbazi left review comments

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit benjaminpetit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 2.2.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@witskeeper @Tratcher @Kahbazi @MihaZupan