Skip to content

[0.66] MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Mar 31, 2022
Merged

[0.66] MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early #9749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d22a4
[0.68] MustBeNoExceptVoidFunctor should depend on the template type p…
JunielKatarn Feb 26, 2022
d52283a
Change files
asklar Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-8a5e8b21-c7ab-4640-badb-cd9cabcd2ad7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (#9609)",
"packageName": "react-native-windows",
"email": "asklar@microsoft.com",
"dependentChangeType": "patch"
}
7 changes: 6 additions & 1 deletion vnext/Mso/dispatchQueue/dispatchQueue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,9 +723,14 @@ inline DispatchTaskImpl<TInvoke, TOnCancel>::~DispatchTaskImpl() noexcept {
}
}

namespace details {
template <typename>
constexpr bool always_false = false;
}

template <typename T>
inline void MustBeNoExceptVoidFunctor() {
static_assert(false, __FUNCTION__ ": not a noexcept callable functor returning void");
static_assert(details::always_false<T>, __FUNCTION__ ": not a noexcept callable functor returning void");
}

template <typename TInvoke, typename TOnCancel>
Expand Down