Skip to content

Change CLI to add prompt if no --template parameter is supplied #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
382c823
merge
kmelmon Aug 13, 2019
85e868b
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 13, 2019
3add306
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 16, 2019
b11daa9
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 16, 2019
a4d97b2
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 20, 2019
e73edc0
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 22, 2019
db46e3b
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 22, 2019
3996c07
Merge remote-tracking branch 'upstream/master'
kmelmon Aug 29, 2019
1d978e2
Merge remote-tracking branch 'upstream/master'
kmelmon Sep 23, 2019
e7e5667
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 3, 2019
e0c0551
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 11, 2019
8230956
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 11, 2019
bdd5758
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 15, 2019
0faddb4
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 16, 2019
928bf26
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 27, 2019
f4637a7
Merge remote-tracking branch 'upstream/master'
kmelmon Nov 2, 2019
d712901
Merge remote-tracking branch 'upstream/master'
kmelmon Nov 20, 2019
ec613ed
Merge remote-tracking branch 'upstream/master'
kmelmon Nov 22, 2019
fbcc7f8
Merge remote-tracking branch 'upstream/master'
kmelmon Nov 23, 2019
ad476c6
Merge remote-tracking branch 'upstream/master'
kmelmon Dec 7, 2019
364e3cd
add prompt
kmelmon Dec 13, 2019
7cda1e7
Change files
kmelmon Dec 16, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "minor",
"comment": "add prompt to CLI",
"packageName": "rnpm-plugin-windows",
"email": "kmelmon@microsoft.com",
"commit": "364e3cd867a026a9f57f0cb526be03bd5300a39d",
"date": "2019-12-16T23:28:08.121Z"
}
14 changes: 10 additions & 4 deletions current/local-cli/rnpm/windows/src/windows.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const Common = require('./common');
const chalk = require('chalk');
const execSync = require('child_process').execSync;
const path = require('path');
const prompt = require('@react-native-community/cli/build/tools/generator/promptSync').default();

const REACT_NATIVE_WINDOWS_GENERATE_PATH = function() {
return path.resolve(
Expand All @@ -24,11 +25,16 @@ module.exports = function (config, args, options) {
const ns = options.namespace ? options.namespace : name;
const version = options.windowsVersion ? options.windowsVersion : Common.getReactNativeVersion();

// If the template is not set, look for a stable or 'rc' version
const template = options.template ? options.template : 'rc';
const ignoreStable = !!options.template;
let template = options.template;
if (!template) {
console.log("What version of react-native-windows would you like to install? Choose one of: legacy, latest [default]:");
template = prompt();
if (template === '') {
template = 'vnext'
}
}

return Common.getInstallPackage(version, template, ignoreStable)
return Common.getInstallPackage(version, template, true)
.then(rnwPackage => {
console.log(`Installing ${rnwPackage}...`);
const pkgmgr = Common.isGlobalCliUsingYarn(process.cwd()) ? 'yarn add' : 'npm install --save';
Expand Down