Skip to content

Bring Narrator focus to XAML island#15611

Merged
vineethkuttan merged 4 commits intomicrosoft:mainfrom
vineethkuttan:xamlislandfocus
Jan 30, 2026
Merged

Bring Narrator focus to XAML island#15611
vineethkuttan merged 4 commits intomicrosoft:mainfrom
vineethkuttan:xamlislandfocus

Conversation

@vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Jan 30, 2026

Description

Earlier for childsite link automation we were fragment-based option. Since XAML island will take care of it automation on its own , we are using framework-based option

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

Why

To bring narrator focus to the XAML island cause of community modules native components are using XAML Island.

Resolves [ #15320 ]

What

Changed automation option for child site to be framework based.

Screenshots

xaml2.mp4

Testing

Tested in playground.

Changelog

Should this change be included in the release notes: yes

Bring Narrator focus to the XAML island

Copy link
Contributor

@iamAbhi-916 iamAbhi-916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamAbhi-916 iamAbhi-916 marked this pull request as ready for review January 30, 2026 13:55
@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner January 30, 2026 13:55
Copy link
Contributor

@protikbiswas100 protikbiswas100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are member fields like m_fragmentRootAutomationProviderRequestedToken still present? If so, should they be removed to avoid dead code/ confusion ?

@vineethkuttan
Copy link
Contributor Author

Are member fields like m_fragmentRootAutomationProviderRequestedToken still present? If so, should they be removed to avoid dead code/ confusion ?

Good eyes. Removed now.

@vineethkuttan vineethkuttan merged commit 27ce28e into microsoft:main Jan 30, 2026
30 checks passed
@vineethkuttan vineethkuttan deleted the xamlislandfocus branch January 30, 2026 16:51
github-actions bot pushed a commit to vineethkuttan/react-native-windows that referenced this pull request Jan 30, 2026
* Use automationoption as frameworkbased for childsite

* Change files

* remove tokens associated with fragment based
Nitin-100 pushed a commit to Nitin-100/react-native-windows that referenced this pull request Jan 31, 2026
* Use automationoption as frameworkbased for childsite

* Change files

* remove tokens associated with fragment based
vineethkuttan added a commit that referenced this pull request Feb 2, 2026
* Use automationoption as frameworkbased for childsite

* Change files

* remove tokens associated with fragment based
@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Feb 2, 2026

@vineethkuttan The fix itself is okay, but let's switch b/w fragment-based and framework-based implementation depending on the flag IReactViewComponentBuilder.XamlSupport. A component created by a builder with this flag set should choose the framework-based option.

This would make this fix wholistic. The RNW core itself would continue to be generic (agnostic of XAML). This would be useful if we've a new derivate of ContentIsland in future (like XamlIsland).

CC: @acoates-ms, @vivekkhare31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabbing Not recognized in Narrator

5 participants