Skip to content

[Fabric] Implement Image body in Image Source RequestImage API #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

[Fabric] Implement Image body in Image Source RequestImage API #14568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e072981
Implement body in Image Source
anupriya13 Apr 17, 2025
a4a87fb
Change files
anupriya13 Apr 17, 2025
7ff7c17
Add test in playground
anupriya13 Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-eed821fc-4d11-4ca3-a820-682d1aba1977.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Implement body in Image Source",
"packageName": "react-native-windows",
"email": "54227869+anupriya13@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/playground/Samples/image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export default class Bootstrap extends React.Component<
: {tintColor: this.state.tintColor},
]}
defaultSource={{uri: this.state.defaultImageUri}}
source={{uri: this.state.imageUri}}
source={{uri: this.state.imageUri, body: 'test'}}
loadingIndicatorSource={{uri: loadingImageUri}}
resizeMode={this.state.selectedResizeMode}
blurRadius={this.state.blurRadius}
Expand Down
7 changes: 7 additions & 0 deletions vnext/Microsoft.ReactNative/Fabric/WindowsImageManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ WindowsImageManager::GetImageRandomAccessStreamAsync(
}
}

if (!source.body.empty()) {
auto bodyContent = winrt::Windows::Web::Http::HttpStringContent(
winrt::to_hstring(source.body), winrt::Windows::Storage::Streams::UnicodeEncoding::Utf8, L"application/json");
request.Content(bodyContent);
}

winrt::Windows::Web::Http::HttpResponseMessage response(co_await m_httpClient.SendRequestAsync(request));

if (!response.IsSuccessStatusCode()) {
Expand Down Expand Up @@ -182,6 +188,7 @@ facebook::react::ImageRequest WindowsImageManager::requestImage(
source.height = imageSource.size.height;
source.width = imageSource.size.width;
source.sourceType = ImageSourceType::Download;
source.body = imageSource.body;

auto progressCallback = [weakObserverCoordinator](int64_t loaded, int64_t total) {
if (auto observerCoordinator = weakObserverCoordinator.lock()) {
Expand Down
1 change: 1 addition & 0 deletions vnext/Microsoft.ReactNative/Utils/ImageUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ struct ReactImageSource {
std::string uri;
std::string method;
std::vector<std::pair<std::string, std::string>> headers;
std::string body;
double width = 0;
double height = 0;
double scale = 1.0;
Expand Down