Introduce ReactNativeAppBuilder #13368
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Introduce ReactNativeAppBuilder.idl", | ||
| "packageName": "react-native-windows", | ||
| "email": "10109130+sharath2727@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #include "pch.h" | ||
| #include "ReactInstanceSettingsBuilder.h" | ||
| #include "ReactInstanceSettingsBuilder.g.cpp" | ||
| #include "ReactInstanceSettings.h" | ||
|
|
||
| namespace winrt::ReactNative { | ||
| using namespace winrt::Microsoft::ReactNative; | ||
| } | ||
|
|
||
| namespace winrt::UI { | ||
| using namespace winrt::Microsoft::UI; | ||
| } | ||
|
|
||
| namespace winrt::Microsoft::ReactNative::implementation { | ||
| ReactInstanceSettingsBuilder::ReactInstanceSettingsBuilder() { | ||
| m_reactInstanceSettings = winrt::make<winrt::ReactNative::implementation::ReactInstanceSettings>(); | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettings ReactInstanceSettingsBuilder::ReactInstanceSettings() { | ||
| return m_reactInstanceSettings; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettingsBuilder ReactInstanceSettingsBuilder::UseDirectDebugger(bool const &state) { | ||
| m_reactInstanceSettings.UseDirectDebugger(state); | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettingsBuilder ReactInstanceSettingsBuilder::UseDeveloperSupport(bool const &state) { | ||
| m_reactInstanceSettings.UseDeveloperSupport(state); | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettingsBuilder ReactInstanceSettingsBuilder::BundleRootPath(hstring const &path) { | ||
| m_reactInstanceSettings.BundleRootPath(path.c_str()); | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettingsBuilder ReactInstanceSettingsBuilder::JavaScriptBundleFile( | ||
| hstring const &file) { | ||
| m_reactInstanceSettings.JavaScriptBundleFile(file.c_str()); | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactInstanceSettingsBuilder ReactInstanceSettingsBuilder::UseFastRefresh(bool const &state) { | ||
| m_reactInstanceSettings.UseFastRefresh(state); | ||
|
|
||
| return *this; | ||
| } | ||
| } // namespace winrt::Microsoft::ReactNative::implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #pragma once | ||
| #include "ReactInstanceSettingsBuilder.g.h" | ||
|
|
||
| namespace winrt::Microsoft::ReactNative::implementation { | ||
| struct ReactInstanceSettingsBuilder : ReactInstanceSettingsBuilderT<ReactInstanceSettingsBuilder> { | ||
| ReactInstanceSettingsBuilder(); | ||
|
|
||
| winrt::Microsoft::ReactNative::ReactInstanceSettings ReactInstanceSettings(); | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder UseDirectDebugger(bool const &state); | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder UseDeveloperSupport(bool const &state); | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder BundleRootPath(hstring const &path); | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder JavaScriptBundleFile(hstring const &file); | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder UseFastRefresh(bool const &state); | ||
|
|
||
| private: | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettings m_reactInstanceSettings{nullptr}; | ||
| }; | ||
| } // namespace winrt::Microsoft::ReactNative::implementation | ||
| namespace winrt::Microsoft::ReactNative::factory_implementation { | ||
| struct ReactInstanceSettingsBuilder | ||
| : ReactInstanceSettingsBuilderT<ReactInstanceSettingsBuilder, implementation::ReactInstanceSettingsBuilder> {}; | ||
| } // namespace winrt::Microsoft::ReactNative::factory_implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| #include "pch.h" | ||
| #include "ReactNativeAppBuilder.h" | ||
| #include "ReactNativeAppBuilder.g.cpp" | ||
| #include "ReactNativeHost.h" | ||
| #include "winrt/Microsoft.UI.Composition.h" | ||
| #include "winrt/Microsoft.UI.Windowing.h" | ||
| #include "winrt/microsoft.UI.Interop.h" | ||
|
|
||
| namespace winrt::ReactNative { | ||
| using namespace winrt::Microsoft::ReactNative; | ||
| } | ||
|
|
||
| namespace winrt::UI { | ||
| using namespace winrt::Microsoft::UI; | ||
| } | ||
|
|
||
| namespace winrt::Microsoft::ReactNative::implementation { | ||
| ReactNativeAppBuilder::ReactNativeAppBuilder() { | ||
| m_host = winrt::make<winrt::ReactNative::implementation::ReactNativeHost>(); | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactNativeAppBuilder ReactNativeAppBuilder::AddPackageProviders( | ||
| winrt::Windows::Foundation::Collections::IVector<winrt::Microsoft::ReactNative::IReactPackageProvider> const | ||
| &packageProviders) { | ||
| for (auto const &provider : packageProviders) { | ||
| m_host.PackageProviders().Append(provider); | ||
| } | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactNativeAppBuilder ReactNativeAppBuilder::SetReactInstanceSettings( | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettings const &settings) { | ||
| m_host.InstanceSettings(settings); | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactNativeAppBuilder ReactNativeAppBuilder::SetCompositor( | ||
| winrt::Microsoft::UI::Composition::Compositor const &compositor) { | ||
| m_compositor = compositor; | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactNativeAppBuilder ReactNativeAppBuilder::SetAppWindow( | ||
| winrt::Microsoft::UI::Windowing::AppWindow const &appWindow) { | ||
| m_appWindow = appWindow; | ||
|
|
||
| return *this; | ||
| } | ||
|
|
||
| winrt::ReactNative::ReactNativeHost ReactNativeAppBuilder::Start() { | ||
| auto hwnd{winrt::UI::GetWindowFromWindowId(m_appWindow.Id())}; | ||
|
|
||
| winrt::ReactNative::ReactCoreInjection::SetTopLevelWindowId( | ||
| m_host.InstanceSettings().Properties(), reinterpret_cast<uint64_t>(hwnd)); | ||
|
|
||
| winrt::ReactNative::Composition::CompositionUIService::SetCompositor(m_host.InstanceSettings(), m_compositor); | ||
|
|
||
sharath2727 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Start the react-native instance, which will create a JavaScript runtime and load the applications bundle. | ||
| m_host.ReloadInstance(); | ||
|
|
||
| return m_host; | ||
| } | ||
| } // namespace winrt::Microsoft::ReactNative::implementation | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #pragma once | ||
| #include "ReactNativeAppBuilder.g.h" | ||
|
|
||
| namespace winrt::Microsoft::ReactNative::implementation { | ||
| struct ReactNativeAppBuilder : ReactNativeAppBuilderT<ReactNativeAppBuilder> { | ||
| ReactNativeAppBuilder(); | ||
|
|
||
| winrt::Microsoft::ReactNative::ReactNativeAppBuilder AddPackageProviders( | ||
| winrt::Windows::Foundation::Collections::IVector<winrt::Microsoft::ReactNative::IReactPackageProvider> const | ||
| &packageProviders); | ||
| winrt::Microsoft::ReactNative::ReactNativeAppBuilder SetReactInstanceSettings( | ||
| winrt::Microsoft::ReactNative::ReactInstanceSettings const &settings); | ||
| winrt::Microsoft::ReactNative::ReactNativeAppBuilder SetCompositor( | ||
| winrt::Microsoft::UI::Composition::Compositor const &compositor); | ||
| winrt::Microsoft::ReactNative::ReactNativeAppBuilder SetAppWindow( | ||
| winrt::Microsoft::UI::Windowing::AppWindow const &appWindow); | ||
| winrt::Microsoft::ReactNative::ReactNativeHost Start(); | ||
|
|
||
| private: | ||
| winrt::Microsoft::UI::Windowing::AppWindow m_appWindow{nullptr}; | ||
| winrt::Microsoft::UI::Composition::Compositor m_compositor{}; | ||
| winrt::Microsoft::ReactNative::ReactNativeHost m_host{}; | ||
| }; | ||
| } // namespace winrt::Microsoft::ReactNative::implementation | ||
| namespace winrt::Microsoft::ReactNative::factory_implementation { | ||
| struct ReactNativeAppBuilder : ReactNativeAppBuilderT<ReactNativeAppBuilder, implementation::ReactNativeAppBuilder> {}; | ||
| } // namespace winrt::Microsoft::ReactNative::factory_implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
|
|
||
| import "ReactNativeHost.idl"; | ||
| import "ReactInstanceSettings.idl"; | ||
| import "IReactPackageProvider.idl"; | ||
|
|
||
| #include "DocString.h" | ||
|
|
||
| namespace Microsoft.ReactNative | ||
| { | ||
| [experimental] | ||
| DOC_STRING("This is the builder for creating ReactInstanceSettings.") | ||
| runtimeclass ReactInstanceSettingsBuilder | ||
|
Contributor
There was a problem hiding this comment. Does this class add much value? Seems like it would quickly become basically the same as the existing ReactInstanceSettings.
Contributor
Author
There was a problem hiding this comment. Yeah I believe it does. It is more of a builder for ReactInstanceSettings. It makes it easy to setup ReactInstanceSettings. Existing ReactInstanceSettings is much more than what this builder is doing. This builder's responsibility is to help setup the settings in one go. |
||
| { | ||
| ReactInstanceSettingsBuilder(); | ||
|
|
||
| // Properties | ||
| ReactInstanceSettings ReactInstanceSettings {get;}; | ||
|
|
||
| // Set Methods | ||
| ReactInstanceSettingsBuilder UseDirectDebugger(Boolean state); | ||
|
|
||
| ReactInstanceSettingsBuilder UseDeveloperSupport(Boolean state); | ||
|
|
||
| ReactInstanceSettingsBuilder BundleRootPath(String path); | ||
|
|
||
| ReactInstanceSettingsBuilder JavaScriptBundleFile(String file); | ||
|
|
||
| ReactInstanceSettingsBuilder UseFastRefresh(Boolean state); | ||
| } | ||
|
|
||
| [experimental] | ||
| DOC_STRING("ReactNativeAppBuilder initializes and manages the ReactNativeHost component for a Win32 Fabric Application.") | ||
| runtimeclass ReactNativeAppBuilder | ||
| { | ||
| ReactNativeAppBuilder(); | ||
|
|
||
| ReactNativeAppBuilder AddPackageProviders(Windows.Foundation.Collections.IVector<Microsoft.ReactNative.IReactPackageProvider> packageProviders); | ||
|
|
||
| ReactNativeAppBuilder SetReactInstanceSettings(ReactInstanceSettings settings); | ||
|
|
||
| ReactNativeAppBuilder SetCompositor(Microsoft.UI.Composition.Compositor compositor); | ||
|
|
||
| ReactNativeAppBuilder SetAppWindow(Microsoft.UI.Windowing.AppWindow appWindow); | ||
|
|
||
| ReactNativeHost Start(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.