-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Area: Borders and BrushesArea: FabricSupport Facebook FabricSupport Facebook FabricNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricBroad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabricbug
Milestone
Description
Problem Description
Looking at the RN docs, most of the core components support both border and shadow props.
The change in PR #12287 added CompositionComponentViewFeatures flags to control whether the CompositionBase ComponentView processes border/shadow props for the subclassed ComponentView. The change also set all components to use CompositionComponentViewFeatures::Default, which is Borders only, which was fine, because each individual ComponentView sublclass processed shadows themselves.
However PR #12474 removed all these manual calls to process shadow props in the subclasses, without updating their feature flags to include the shadow props.
Steps To Reproduce
This was seen through static analysis.
Expected Results
No response
CLI version
npx react-native -v
Environment
npx react-native infoTarget Platform Version
None
Target Device(s)
Desktop
Visual Studio Version
None
Build Configuration
None
Snack, code example, screenshot, or link to a repository
No response
Metadata
Metadata
Assignees
Labels
Area: Borders and BrushesArea: FabricSupport Facebook FabricSupport Facebook FabricNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricBroad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabricbug
Type
Projects
Status
Done