Skip to content

Commit ea88135

Browse files
authored
Use Upstream TopClick Type Instead of Windows-Specific Type (#11969)
* Use Bubbling TopClick * Change files * Fix Type Expectations
1 parent 6bd090e commit ea88135

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Use Bubbling TopClick",
4+
"packageName": "react-native-windows",
5+
"email": "34109996+chiaramooney@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

vnext/Microsoft.ReactNative/Views/ViewViewManager.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,6 @@ void ViewViewManager::GetExportedCustomDirectEventTypeConstants(
243243
const winrt::Microsoft::ReactNative::IJSValueWriter &writer) const {
244244
Super::GetExportedCustomDirectEventTypeConstants(writer);
245245

246-
writer.WritePropertyName(L"topClick");
247-
writer.WriteObjectBegin();
248-
winrt::Microsoft::ReactNative::WriteProperty(writer, L"registrationName", L"onClick");
249-
writer.WriteObjectEnd();
250-
251246
writer.WritePropertyName(L"topAccessibilityTap");
252247
writer.WriteObjectBegin();
253248
winrt::Microsoft::ReactNative::WriteProperty(writer, L"registrationName", L"onAccessibilityTap");

vnext/src/Libraries/NativeComponent/BaseViewConfig.windows.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,13 @@ const bubblingEventTypes = {
8383
captured: 'onTouchEndCapture',
8484
},
8585
},
86-
8786
// Experimental/Work in Progress Pointer Events (not yet ready for use)
88-
/*[Windows
8987
topClick: {
9088
phasedRegistrationNames: {
9189
captured: 'onClickCapture',
9290
bubbled: 'onClick',
9391
},
9492
},
95-
Windows] */
9693
topPointerCancel: {
9794
phasedRegistrationNames: {
9895
captured: 'onPointerCancelCapture',
@@ -202,9 +199,6 @@ const directEventTypes = {
202199
topMouseLeave: {
203200
registrationName: 'onMouseLeave',
204201
},
205-
topClick: {
206-
registrationName: 'onClick',
207-
},
208202
// Windows]
209203
};
210204

0 commit comments

Comments
 (0)