Commit 5fd67d7
authored
Point Desktop.IntegrationTests::HttpResourceIntegrationTests to a non-rate limited API (#12056)
## Description
There are three tests in `Desktop.Integration`'s `HttpResourceIntegrationTests` which verify that requests against a server that requires a `User-Agent` will succeed with the header present and fail when it's missing.
To do this we're using a standard unauthenticated GitHub API endpoint.
However, we can also hit rate limiting on this endpoint, causing the tests to fail. This PR improves the stability of those tests by instead hitting an API with the same Header requirement, but without rate limiting.
### Type of Change
- Bug fix (non-breaking change which fixes an issue)
### Why
Stop good PRs from failing due to rate limiting causing tests to fail sporadically.
### What
Instead of hitting random GitHub API endpoints (and getting caught in unauthenticated rate limiting), instead change to calling the `/rate_limit` API, which has no rate limit itself.
## Screenshots
N/A
## Testing
Ran integration tests.
## Changelog
Should this change be included in the release notes: No1 parent c030b7c commit 5fd67d7
File tree
2 files changed
+10
-3
lines changed- change
- vnext/Desktop.IntegrationTests
2 files changed
+10
-3
lines changedLines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
| 172 | + | |
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
0 commit comments