Skip to content

Commit 6229cc2

Browse files
authored
fix(android): bump Gradle wrapper version for 0.80+ (#2502)
1 parent 3abb2d2 commit 6229cc2

File tree

9 files changed

+32
-26
lines changed

9 files changed

+32
-26
lines changed

.swiftlint.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ disabled_rules:
33
- opening_brace # Conflicts with SwiftFormat
44
- trailing_comma
55
excluded:
6+
- example/*/DerivedData/
67
- example/*/Pods/
8+
- example/*/build/
79
- example/node_modules/
810
- node_modules/

android/gradle-wrapper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const INT_MAX = 2 ** 31 - 1;
3434
* @type {[number, [number, string], [number, string]][]}
3535
*/
3636
const GRADLE_VERSIONS = [
37-
[v(0, 80, 0), [v(8, 14, 1), "8.14.1"], [INT_MAX, ""]], // 0.80: [8.14.1, *)
37+
[v(0, 80, 0), [v(8, 14, 3), "8.14.3"], [INT_MAX, ""]], // 0.80: [8.14.3, *)
3838
[v(0, 79, 0), [v(8, 13, 0), "8.13"], [INT_MAX, ""]], // 0.79: [8.13, *)
3939
[v(0, 78, 0), [v(8, 12, 0), "8.12"], [INT_MAX, ""]], // 0.78: [8.12, *)
4040
[v(0, 76, 0), [v(8, 11, 1), "8.11.1"], [INT_MAX, ""]], // 0.76: [8.11.1, *)

ios/ReactTestApp/ContentView.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ final class ContentViewController: UITableViewController {
3939
private let reactInstance: ReactInstance
4040
private var sections: [SectionData]
4141

42-
public init(reactInstance: ReactInstance) {
42+
init(reactInstance: ReactInstance) {
4343
self.reactInstance = reactInstance
4444
sections = []
4545

@@ -53,7 +53,7 @@ final class ContentViewController: UITableViewController {
5353

5454
// MARK: - UIResponder overrides
5555

56-
override public func motionEnded(_: UIEvent.EventSubtype, with event: UIEvent?) {
56+
override func motionEnded(_: UIEvent.EventSubtype, with event: UIEvent?) {
5757
guard event?.subtype == .motionShake, let host = reactInstance.host else {
5858
return
5959
}
@@ -73,7 +73,7 @@ final class ContentViewController: UITableViewController {
7373

7474
// MARK: - UIViewController overrides
7575

76-
override public func viewDidLoad() {
76+
override func viewDidLoad() {
7777
super.viewDidLoad()
7878

7979
let manifest = Manifest.load()
@@ -154,21 +154,21 @@ final class ContentViewController: UITableViewController {
154154

155155
// MARK: - UITableViewDelegate overrides
156156

157-
override public func tableView(_: UITableView, shouldHighlightRowAt indexPath: IndexPath) -> Bool {
157+
override func tableView(_: UITableView, shouldHighlightRowAt indexPath: IndexPath) -> Bool {
158158
indexPath.section == Section.components
159159
}
160160

161-
override public func tableView(_: UITableView, didSelectRowAt indexPath: IndexPath) {
161+
override func tableView(_: UITableView, didSelectRowAt indexPath: IndexPath) {
162162
sections[indexPath.section].items[indexPath.row].action?()
163163
}
164164

165165
// MARK: - UITableViewDataSource overrides
166166

167-
override public func tableView(_: UITableView, numberOfRowsInSection section: Int) -> Int {
167+
override func tableView(_: UITableView, numberOfRowsInSection section: Int) -> Int {
168168
sections[section].items.count
169169
}
170170

171-
override public func tableView(_: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
171+
override func tableView(_: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
172172
let link = sections[indexPath.section].items[indexPath.row]
173173
let cell = UITableViewCell(style: .default, reuseIdentifier: "cell")
174174

@@ -193,11 +193,11 @@ final class ContentViewController: UITableViewController {
193193
return cell
194194
}
195195

196-
override public func numberOfSections(in _: UITableView) -> Int {
196+
override func numberOfSections(in _: UITableView) -> Int {
197197
sections.count
198198
}
199199

200-
override public func tableView(_: UITableView, titleForFooterInSection section: Int) -> String? {
200+
override func tableView(_: UITableView, titleForFooterInSection section: Int) -> String? {
201201
sections[section].footer
202202
}
203203

ios/ReactTestApp/ReactInstance.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import ReactNativeHost
33
import ReactTestApp_DevSupport
44

55
final class ReactInstance: NSObject, RNXHostConfig {
6-
public static let scanForQRCodeNotification =
6+
static let scanForQRCodeNotification =
77
NSNotification.Name("ReactInstance.scanForQRCodeNotification")
88

99
static func jsBundleURL() -> URL? {

test/android/gradle-wrapper.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ describe("configureGradleWrapper()", () => {
135135
process.argv.push("run-android");
136136

137137
const cases = [
138-
["8.14", "0.80.0", "gradle-8.14.1-bin.zip"],
138+
["8.14", "0.80.0", "gradle-8.14.3-bin.zip"],
139139
["8.12", "0.79.0", "gradle-8.13-bin.zip"],
140140
["8.11.1", "0.78.0", "gradle-8.12-bin.zip"],
141141
["8.9", "0.76.0", "gradle-8.11.1-bin.zip"],
@@ -193,7 +193,7 @@ describe("configureGradleWrapper()", () => {
193193
process.argv.push("run-android");
194194

195195
const cases = [
196-
["8.14.1", "0.80.0"],
196+
["8.14.3", "0.80.0"],
197197
["8.13", "0.79.0"],
198198
["8.12", "0.78.0"],
199199
["8.11.1", "0.76.0"],

tsconfig.cjs.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "@rnx-kit/tsconfig/tsconfig.json",
2+
"extends": "@rnx-kit/tsconfig/tsconfig.node.json",
33
"compilerOptions": {
44
"noEmit": true
55
},

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
2+
"extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
33
"compilerOptions": {
44
"target": "ES2022",
55
"module": "ES2022",

windows/app.mjs

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -258,14 +258,18 @@ export async function generateSolution(destPath, options, fs = nodefs) {
258258
const { msbuildprops, useHermes } = options;
259259
const { useExperimentalNuGet, useFabric, versionNumber } = info;
260260
const url = new URL(experimentalFeaturesPropsFilename, import.meta.url);
261-
copyAndReplaceAsync(fileURLToPath(url), experimentalFeaturesPropsPath, {
262-
"<RnwNewArch>false</RnwNewArch>": `<RnwNewArch>${useFabric}</RnwNewArch>`,
263-
"<UseFabric>false</UseFabric>": `<UseFabric>${useFabric}</UseFabric>`,
264-
"<UseHermes>true</UseHermes>": `<UseHermes>${useHermes == null ? versionNumber >= v(0, 73, 0) : useHermes}</UseHermes>`,
265-
"<UseWinUI3>false</UseWinUI3>": `<UseWinUI3>${useFabric}</UseWinUI3>`,
266-
"<UseExperimentalNuget>false</UseExperimentalNuget>": `<UseExperimentalNuget>${useExperimentalNuGet}</UseExperimentalNuget>`,
267-
"<!-- AdditionalMSBuildProperties -->": msbuildprops ?? "",
268-
});
261+
await copyAndReplaceAsync(
262+
fileURLToPath(url),
263+
experimentalFeaturesPropsPath,
264+
{
265+
"<RnwNewArch>false</RnwNewArch>": `<RnwNewArch>${useFabric}</RnwNewArch>`,
266+
"<UseFabric>false</UseFabric>": `<UseFabric>${useFabric}</UseFabric>`,
267+
"<UseHermes>true</UseHermes>": `<UseHermes>${useHermes == null ? versionNumber >= v(0, 73, 0) : useHermes}</UseHermes>`,
268+
"<UseWinUI3>false</UseWinUI3>": `<UseWinUI3>${useFabric}</UseWinUI3>`,
269+
"<UseExperimentalNuget>false</UseExperimentalNuget>": `<UseExperimentalNuget>${useExperimentalNuGet}</UseExperimentalNuget>`,
270+
"<!-- AdditionalMSBuildProperties -->": msbuildprops ?? "",
271+
}
272+
);
269273
}
270274

271275
if (info.useExperimentalNuGet) {

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3960,9 +3960,9 @@ __metadata:
39603960
linkType: hard
39613961

39623962
"@rnx-kit/tsconfig@npm:^2.0.0":
3963-
version: 2.0.1
3964-
resolution: "@rnx-kit/tsconfig@npm:2.0.1"
3965-
checksum: 10c0/28acc7c2d82be18dd3ec360222ece40981c137b6532df39ffbfdc7996af9818e6abf2a1f583923be07faf06ce8bf3a0b95c3d41680d67b05459a0d7ad4ed4235
3963+
version: 2.1.1
3964+
resolution: "@rnx-kit/tsconfig@npm:2.1.1"
3965+
checksum: 10c0/53aed185abd644250d95c732e44ecb66bcdf3005cc6eb854ba217346fa29cf0ea892bbd391e15050a5b553fe7dc983130add30c9aa30b1f66a0ca498d3409d94
39663966
languageName: node
39673967
linkType: hard
39683968

0 commit comments

Comments
 (0)