Skip to content

Conversation

@acoates-ms
Copy link
Collaborator

These are patches for office's internal usage. They need to be updated to account for the latest changes synced from react-native.

@acoates-ms acoates-ms requested a review from alloy as a code owner August 4, 2021 17:47
@pull-bot
Copy link

pull-bot commented Aug 4, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ad192c6

@acoates-ms acoates-ms merged commit 30f1e3b into microsoft:master Aug 4, 2021
@acoates-ms acoates-ms deleted the fixpatches branch August 4, 2021 19:39
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants