scroll content with animation #725
Conversation
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
There was a problem hiding this comment.
Perhaps the magic number used as duration could be moved to the top of the file, but otherwise the change seems good to me 👍
One thing that would worry me slightly is the whitespace changes, which may make it harder to merge in upstream changes in the future, but I’ll defer to @HeyImChris on that.
|
Just a heads up this failed the CI with an error that we intermittently hit. Very confident it's unrelated to your change so I kicked off another build that will hopefully succeed and then we can merge this in |
I agree that it'd be great to move all constants to the top. As for the whitespace... it's definitely a noble change. Maybe we can make the same whitespace fixes upstream too so we don't hit merge problems later? @marty-wang |
will do |
|
Btw, this fixes #706 |
Thanks- merged! |
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Update RCTCxxBridge.mm * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * Update RCTCxxBridge.mm * add quotes * switch to catalina * update pods to 10.15 * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * switch to catalina * update pods to 10.15 * upgrade version requirements to n-2 for osx * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * switch to catalina * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * CI should run on PRs to future stable branches (#718) * Pull in header's C declaration to stop symbol mangling (#728) * Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * fix undefined extern c symbol * scroll content with animation (#725) Summary: please see test plan Test Plan: |Before|After| |{F371503806}|{F371499708}| Reviewers: skyle Reviewed By: skyle Subscribers: zackargyle Differential Revision: https://phabricator.intern.facebook.com/D26354172 Tasks: T84165504 Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e Co-authored-by: Mo Wang <mowang@fb.com> * Fix missing props on secure text input (#719) * Enable animated gif playback on Mac (#724) * enable gif for mac Summary: I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not. Test Plan: |{F369886201}|{F369889196}| Reviewers: skyle Reviewed By: skyle Subscribers: zackargyle Differential Revision: https://phabricator.intern.facebook.com/D26272145 Tasks: T82742678 Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5 * bypass setImage logic when it is Mac Summary: as titled Test Plan: {F370138978} {F370139033} Reviewers: skyle Reviewed By: skyle Subscribers: zackargyle Differential Revision: https://phabricator.intern.facebook.com/D26288169 Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4 * address PR comments * address PR comments 1 Co-authored-by: Mo Wang <mowang@fb.com> * Add explicit Tab support to keyboarding (#723) * Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * add explicit tab support * missing tab validity check * Fix Deadlock in RCTi18nUtil (iOS) (#733) * Initial Commit * Fix typo * Fix default initialization of isRTLAllowed and documentation * use BOOL, remove superfluous readwrite decorator * Fix another typo * Add TODO Marker * update to macOS 10.15 * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * switch to catalina * update pods to 10.15 * upgrade version requirements to n-2 for osx * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * switch to catalina * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * make CI xcode versioning more robust to xcode12 * update to xcode 12.4 * use apple variables file * add quotes * update to macOS 10.15 * update to xcode 12.4 * use apple variables file * switch to catalina * 10.14 * CI has to run on 10.15.4 or later * fix up pod errors * upgrade iphone simulator * iphone 13 * remove old post install script * iphone 8 * Restore Podfile.lock to see if it fixes CI * Restore compiler flags in TurboModuleCxx-WinRTPort * Remove macOS arm64 build divergence * Remove building all ARCHS temporarily * Override ONLY_ACTIVE_ARCH in release builds too * Push iOS 14 snapshots Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Mo <mo.hy.wang@gmail.com> Co-authored-by: Mo Wang <mowang@fb.com> Co-authored-by: Scott Kyle <scott@appden.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Please select one of the following
Summary
This PR fixes the issue where the scrollbar does not move/animate when scrollToOffset/End is called.
Changelog
[macOS] [Fixed] - Fixes the issue where the scrollbar does not move/animate when scrollToOffset/End is called
Test Plan
Screen.Recording.2021-02-13.at.10.20.08.AM.mov
Microsoft Reviewers: Open in CodeFlow