Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should run on PRs to future stable branches #718

Merged
merged 1 commit into from
Feb 12, 2021
Merged

CI should run on PRs to future stable branches #718

merged 1 commit into from
Feb 12, 2021

Conversation

acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Feb 10, 2021 •
edited by ghost
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This will ensure that the CI builds run on future stable branches.

Microsoft Reviewers: Open in CodeFlow

@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 5e6227f

@HeyImChris HeyImChris merged commit ab9d649 into microsoft:master Feb 12, 2021
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Feb 23, 2021
@acoates-ms @HeyImChris
CI should run on PRs to future stable branches (microsoft#718)
2845582
HeyImChris added a commit that referenced this pull request Feb 23, 2021
@HeyImChris @acoates-ms
Fix 63 CI to run on all stable branches (#734)
46993a0 
* Add nullability checks (#704)

* Update RCTCxxBridge.mm

* add nullability checks

* CI should run on PRs to future stable branches (#718)

Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
HeyImChris added a commit that referenced this pull request Feb 26, 2021
@HeyImChris @acoates-ms
@sergi @alloy
Fix 0.63-stable CI, remove (#735)
21cfd79 
* Add nullability checks (#704)

* Update RCTCxxBridge.mm

* add nullability checks

* CI should run on PRs to future stable branches (#718)

* Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (#678)

* Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces

* [ado] Remove no longer needed homebrew fix

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* update podfile.lock

* Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (#678)

* Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces

* [ado] Remove no longer needed homebrew fix

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* update podfile.lock

* windows dep updates to 63

Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Sergi Mansilla <sergi@sergimansilla.com>
Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Mar 2, 2021
@acoates-ms @HeyImChris
CI should run on PRs to future stable branches (microsoft#718)
6449ad5
HeyImChris added a commit that referenced this pull request Mar 17, 2021
@HeyImChris @acoates-ms
@marty-wang @appden @Saadnajmi @anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e 
* Update RCTCxxBridge.mm

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* Update RCTCxxBridge.mm

* add quotes

* switch to catalina

* update pods to 10.15

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* switch to catalina

* update pods to 10.15

* upgrade version requirements to n-2 for osx

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* switch to catalina

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* CI should run on PRs to future stable branches (#718)

* Pull in header's C declaration to stop symbol mangling  (#728)

* Update RCTCxxBridge.mm

* Update RCTCxxBridge.mm

* fix undefined extern c symbol

* scroll content with animation (#725)

Summary: please see test plan

Test Plan:
|Before|After|
|{F371503806}|{F371499708}|



Reviewers: skyle

Reviewed By: skyle

Subscribers: zackargyle

Differential Revision: https://phabricator.intern.facebook.com/D26354172

Tasks: T84165504

Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e

Co-authored-by: Mo Wang <mowang@fb.com>

* Fix missing props on secure text input (#719)

* Enable animated gif playback on Mac (#724)

* enable gif for mac

Summary:
I verify that it works for Zeratul as well. 

It also works regardless turbo module is enabled or not.

Test Plan: 
|{F369886201}|{F369889196}|



Reviewers: skyle

Reviewed By: skyle

Subscribers: zackargyle

Differential Revision: https://phabricator.intern.facebook.com/D26272145

Tasks: T82742678

Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5

* bypass setImage logic when it is Mac

Summary: as titled

Test Plan:

{F370138978}

{F370139033}


Reviewers: skyle

Reviewed By: skyle

Subscribers: zackargyle

Differential Revision: https://phabricator.intern.facebook.com/D26288169

Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4

* address PR comments

* address PR comments 1

Co-authored-by: Mo Wang <mowang@fb.com>

* Add explicit Tab support to keyboarding (#723)

* Update RCTCxxBridge.mm

* Update RCTCxxBridge.mm

* add explicit tab support

* missing tab validity check

* Fix Deadlock in RCTi18nUtil (iOS) (#733)

* Initial Commit

* Fix typo

* Fix default initialization of isRTLAllowed and documentation

* use BOOL, remove superfluous readwrite decorator

* Fix another typo

* Add TODO Marker

* update to macOS 10.15

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* switch to catalina

* update pods to 10.15

* upgrade version requirements to n-2 for osx

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* switch to catalina

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* make CI xcode versioning more robust to xcode12

* update to xcode 12.4

* use apple variables file

* add quotes

* update to macOS 10.15

* update to xcode 12.4

* use apple variables file

* switch to catalina

* 10.14

* CI has to run on 10.15.4 or later

* fix up pod errors

* upgrade iphone simulator

* iphone 13

* remove old post install script

* iphone 8

* Restore Podfile.lock to see if it fixes CI

* Restore compiler flags in TurboModuleCxx-WinRTPort

* Remove macOS arm64 build divergence

* Remove building all ARCHS temporarily

* Override ONLY_ACTIVE_ARCH in release builds too

* Push iOS 14 snapshots

Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
@acoates-ms acoates-ms deleted the stableci branch September 2, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajeswaran anandrajeswaran anandrajeswaran approved these changes

@HeyImChris HeyImChris HeyImChris approved these changes

@alloy alloy Awaiting requested review from alloy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acoates-ms @pull-bot @HeyImChris @anandrajeswaran