Skip to content

Prevent race where devSettings property is called before bridge is do… #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Prevent race where devSettings property is called before bridge is do… #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b512e
Prevent race where devSettings property is called before bridge is do…
tom-un Apr 3, 2019
a863824
Changed klass to devSettingsClass
tom-un Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion React/Modules/RCTDevSettings.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,12 @@ @implementation RCTBridge (RCTDevSettings)
- (RCTDevSettings *)devSettings
{
#if RCT_DEV
return [self moduleForClass:[RCTDevSettings class]];
RCTDevSettings *devSettings = nil; // [TODO(OSS Candidate ISS#2710739)
Class devSettingsClass = [RCTDevSettings class];
if ([self moduleIsInitialized:devSettingsClass]) {
devSettings = [self moduleForClass:devSettingsClass];
}
return devSettings; // ]TODO(OSS Candidate ISS#2710739)
#else
return nil;
#endif
Expand Down