ci: update preid check in prepublish.mjs #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Mar 24, 2025
Saadnajmi
changed the title
tido64
approved these changes
Mar 25, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 25, 2025
`prerelease` can be `undefined` while `generatorOptions.preid` is an empty string. Update the check to handle that CI should pass
Saadnajmi
added a commit
that referenced
this pull request
Mar 25, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
## Summary: `prerelease` can be `undefined` while `generatorOptions.preid` is an empty string. Update the check to handle that ## Test Plan: CI should pass
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
## Summary: `prerelease` can be `undefined` while `generatorOptions.preid` is an empty string. Update the check to handle that ## Test Plan: CI should pass
This was referenced Mar 26, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
prereleasecan beundefinedwhilegeneratorOptions.preidis an empty string. Update the check to handle thatTest Plan:
CI should pass