Skip to content

Conversation

@Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Apr 21, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Merge to right before the monorepo commit.

Notable changes:

  • NodeJS updated to 18
  • Flatlist moved to it's own package
  • RCTSurfaceTouchHandler heavily refactored, with much extracted to RCTSurfacePointerHandler
  • setColorScheme added
  • Support for Legacy native views in Fabric added (See RNTMyLegacyView)

Changelog

[GENERAL] [ADDED] - Merge to commit before monorepo change

Test Plan

CI should pass.
setColorScheme works
https://user-images.githubusercontent.com/6722175/233556551-f667bfeb-f544-4d14-a11d-ccaeb18d74b3.mov

@Saadnajmi Saadnajmi requested a review from a team as a code owner April 21, 2023 04:37
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️

Libraries/LayoutAnimation/LayoutAnimation.js#L13 - Libraries/LayoutAnimation/LayoutAnimation.js line 13 – 'FabricUIManagerSpec' is defined but never used. (no-unused-vars)

⚠️

Libraries/ReactNative/UIManager.js#L12 - Libraries/ReactNative/UIManager.js line 12 – 'FabricUIManagerSpec' is defined but never used. (no-unused-vars)

⚠️

packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js#L285 - packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 285 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)

⚠️

packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js#L289 - packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 289 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)

⚠️

scripts/publish-npm.js#L176 - scripts/publish-npm.js line 176 – 'tagFlag' is assigned a value but never used. (no-unused-vars)

⚠️

scripts/publish-npm.js#L185 - scripts/publish-npm.js line 185 – 'otpFlag' is assigned a value but never used. (no-unused-vars)

Generated by 🚫 dangerJS against e50ab82

@Saadnajmi Saadnajmi force-pushed the before-monorepo branch 6 times, most recently from 52449e6 to fbf6025 Compare April 21, 2023 18:34
@amgleitman
Copy link
Member

Have we done any testing for the other notable changes?

@Saadnajmi
Copy link
Collaborator Author

Have we done any testing for the other notable changes?

No not really. This really was just a working draft. Feel free to re-do it if that works better for you.

@Saadnajmi Saadnajmi closed this Jul 29, 2023
@Saadnajmi Saadnajmi deleted the before-monorepo branch August 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants