Fix coordinates of touch.pageX/pageY coordinates when RCTRootView is not at the origin of the NSWindow #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew." This reverts commit 5a67ae0.
…not at the origin of the NSWindow
Saadnajmi
approved these changes
Jan 5, 2023
Collaborator
Saadnajmi
left a comment
Saadnajmi
left a comment
There was a problem hiding this comment.
Thanks for the fix! Let me know if you need this merged if you don't have merge permissions. Also if it needs to be back ported.
Collaborator
Author
|
Thanks @Saadnajmi ! Yes, this should be back ported to .68 -- the version currently deployed in Office, and any newer version that may be being prepared for deployment. |
Collaborator
We're currently doing the 71 merge on the main branch, so you should only need to make one more PR to 0.68-stable (we're skipping 0.69 and 0.70). |
tom-un
added a commit
to tom-un/react-native
that referenced
this pull request
Jan 6, 2023
…not at the origin of the NSWindow (microsoft#1619) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix coordinates of touch.pageX/pageY coordinates when RCTRootView is not at the origin of the NSWindow Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
If the
RCTRootViewis not positioned at the origin of theNSWindow, thentouch.pageX/pageYevents will not have the correct coordinates. This can make it difficult for a user to click onTouchableandPressablecomponents unless there are no mouse moves between the mouse down and the mouse up events. The touch down and up events use thetouch.locationX/locationYwhich are computed correctly, but after a touch down if the user move the mouse thetouch.pageX/pageYcoordinates are used and if theRCTRootViewis not at the window origin, these coordinates will be offset. The result is the user will see touch feedback for a moment and then it disappears.Changelog
[macOS] [Fixed] - Fix coordinates of touch.pageX/pageY coordinates when RCTRootView is not at the origin of the NSWindow
Test Plan
This issue only manifests if the
RCTRootViewis not at the origin of theNSWindow. To test this bug, I modifiedpackages/rn-tester/RNTester-macOS/ViewController.madding[rootView setFrameOrigin:(NSPoint){0,-100}];at the end ofviewDidLoad.In the "Pressable" page, click on the first "Press Me" button and notice that it correctly changes to "Pressed!" back to "Press Me" if the mouse is dragged out of the Pressable.
This resolved #1618