[Fabric] Convert UISlider to RCTSlider shim #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait... is Slider not supposed to be ejected from RN Core? |
|
OK, this is one of many PRs just replacing everything in place. I see. |
shwanton
changed the title
Saadnajmi
reviewed
Dec 6, 2022
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
requested changes
Dec 6, 2022
ghost
added
the
Saadnajmi
approved these changes
Dec 6, 2022
4 tasks
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UISlider to RCTUISlider shim * Add macOS tags * Refactor RCTSlider to RCTUISlider for Fabric Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UISlider to RCTUISlider shim * Add macOS tags * Refactor RCTSlider to RCTUISlider for Fabric Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
* [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UISlider to RCTUISlider shim * Add macOS tags * Refactor RCTSlider to RCTUISlider for Fabric Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Replacing references of UISlider to RCTSlider shim
Changelog
[macOS][Fabric] - Replacing references of UISlider to RCTSlider shim
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no UISlider errors
Build errors:
Build RNTester-macOS_2022-11-28T14-57-11.txt
[x] Build RNTester - iOS w/ Fabric - New architecture example should work
https://user-images.githubusercontent.com/96719/204399184-5609e029-d853-4835-8cc2-47ded88c9583.mp4
[x] Build RNTester-macOS w/ Paper - should work
[x] Build RNTester - iOS w/ Paper - should work
