Skip to content

[0.66] Deprecate onScrollKeyDown, refactor Flatlist selection logic #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 26, 2022
Merged

[0.66] Deprecate onScrollKeyDown, refactor Flatlist selection logic #1375

merged 6 commits into from
Aug 26, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Reverts #1306 , Cherry picks #1338 and #1365 to 0.66-stable

Changelog

[macOS] [Fixed] - Deprecate onScrollKeyDown

Saadnajmi and others added 3 commits August 24, 2022 22:03
@Saadnajmi
Revert "Revert Flatlist changes (microsoft#1306)"
ab0a6c7 
This reverts commit 8ce9545.
@christophpurrer @appden @Saadnajmi
Refactor handling of keyDown/keyUp (microsoft#1338)
70ffa83 
This refactors / simplifies certain keyUp|Down event handling.
It will make a later change (adding textInput handling for textInput fields) easier (to review)

Co-authored-by: Scott Kyle <skyle@fb.com>
@Saadnajmi
Deprecate onScrollKeyDown, refactor Flatlist selection logic (microso…
33c559f 
…ft#1365)

* Deprecate onScrollKeyDown

remove pressable diff

Remove JS handling for PageUp/Down, fix flow errors

Add back "autoscroll to focused view" behavior

remove commented code

remove change to pressable

Update documentation

fix flow error

fix lint issue

Fix 'selectRowAtIndex'

More simplification

lock

* Make method public again

* Add initialSelectedIndex

* macOS tags

* fix lint
@Saadnajmi Saadnajmi requested a review from a team as a code owner August 25, 2022 05:12
@pull-bot
Copy link

pull-bot commented Aug 25, 2022 •
edited
Loading

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 0dbab8c

analysis-bot
analysis-bot suggested changes Aug 25, 2022
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

@ghost ghost removed the Needs: Author Feedback label Aug 25, 2022
@Saadnajmi
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Saadnajmi
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Saadnajmi Saadnajmi merged commit 0cd3092 into microsoft:0.66-stable Aug 26, 2022
@Saadnajmi Saadnajmi deleted the flatlist-66 branch August 31, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analysis-bot analysis-bot analysis-bot requested changes

@chiuam chiuam chiuam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Saadnajmi @pull-bot @analysis-bot @chiuam @christophpurrer