change tags

Author: Saadnajmi

.circleci/Dockerfiles/Dockerfile.android

@@ -21,7 +21,7 @@
 # Patch it to use mcr for the base ubuntu image, build the community image locally
 # and then build this customized step on top of it.
 #
-# Disabeling this is okay because per (macOS GH#774) this test, which is redundant to Azure Devops test,
+# Disabling this is okay because per (Github#774) this test, which is redundant to Azure Devops test,
 # failsin the fork because of Microsoft's V8 upgrade to Android
 #
 #FROM reactnativecommunity/react-native-android:5.2

.circleci/config.yml

@@ -329,7 +329,7 @@ jobs:
       - run:
           name: "Run Tests: JavaScript Tests"
           command: node ./scripts/run-ci-javascript-tests.js --maxWorkers 2
-      # TODO(macOS GH#949): Disable this failing test
+      # [macOS] Disable this failing test
       # - run_e2e:
       #     platform: js
 
@@ -904,12 +904,12 @@ workflows:
           run_disabled_tests: false
           filters:
             branches:
-              # TODO(macOS GH#774): disable this test which is redundant to Azure Devops test and it requires a CCI plan with resource-class:large.
+              # [macOS] disable this test which is redundant to Azure Devops test and it requires a CCI plan with resource-class:large.
               ignore: /.*/
       - test_android_template:
           filters:
             branches:
-              # TODO(macOS GH#774): disable this test which is redundant to Azure Devops test and it requires a CCI plan with resource-class:large.
+              # [macOS] disable this test which is redundant to Azure Devops test and it requires a CCI plan with resource-class:large.
               ignore: /.*/
       - test_ios_template:
           requires:
@@ -941,7 +941,7 @@ workflows:
       #     use_hermes: true
       #     use_frameworks: true
       #     run_unit_tests: true
-      # TODO(macOS GH#949): Disable this failing test
+      # [macOS] Disable this failing test
       # - test_js:
       #     name: test_js_prev_lts
       #     executor: nodeprevlts
@@ -951,15 +951,15 @@ workflows:
       - test_docker:
           filters:
             branches:
-              # TODO(macOS GH#774): disable this test which is redundant to Azure Devops test and in the fork it fails because of Microsoft's V8 upgrade to Android
+              # [macOS] disable this test which is redundant to Azure Devops test and in the fork it fails because of Microsoft's V8 upgrade to Android
               ignore: /.*/
       - test_windows:
           filters:
             branches:
-              # [TODO(macOS GH#774): disable this test which requires a CCI plan.
+              # [macOS disable this test which requires a CCI plan.
               # ignore: gh-pages
               ignore: /.*/
-              # ]TODO(macOS GH#774)
+              # macOS]
           run_disabled_tests: false
 
   # This workflow should only be triggered by release script
@@ -1009,23 +1009,23 @@ workflows:
 
       # Gather coverage
       - js_coverage:
-          # [TODO(macOS GH#774): disable this test, it fails in the fork due to not being set up for coveralls
+          # [macOS disable this test, it fails in the fork due to not being set up for coveralls
           filters:
             branches:
               ignore: /.*/
-          # ]TODO(macOS GH#774)
+          # macOS]
   nightly:
     unless: << pipeline.parameters.run_package_release_workflow_only >>
     triggers:
       - schedule:
           cron: "0 20 * * *"
           filters:
             branches:
-              # [TODO(macOS GH#774): disable this release.  We never want to release anything from this fork via CCI.
+              # [macOS disable this release.  We never want to release anything from this fork via CCI.
               ignore: /.*/
               # only:
               #   - main
-              # ]TODO(macOS GH#774)
+              # macOS]
     jobs:
       - nightly_job
 

.flowconfig

@@ -1,7 +1,7 @@
 [ignore]
 ; We fork some components by platform
 .*/*[.]android.js
-; TODO(macOS GH#774):
+; macOS
 .*/*[.]macos.js
 
 ; Ignore templates for 'react-native init'
@@ -13,7 +13,7 @@
 ; Ignore "BUCK" generated dirs
 <PROJECT_ROOT>/\.buckd/
 
-; TODO(macOS GH#774): Ignore metro.config.js
+; macOS: Ignore metro.config.js
 <PROJECT_ROOT>/metro.config.js
 
 ; Flow doesn't support platforms

.flowconfig.android

@@ -1,7 +1,7 @@
 [ignore]
 ; We fork some components by platform
 .*/*[.]ios.js
-; TODO(macOS GH#774):
+; macOS
 .*/*[.]macos.js
 
 ; Ignore templates for 'react-native init'
@@ -13,7 +13,7 @@
 ; Ignore "BUCK" generated dirs
 <PROJECT_ROOT>/\.buckd/
 
-; TODO(macOS GH#774): Ignore metro.config.js
+; macOS: Ignore metro.config.js
 <PROJECT_ROOT>/metro.config.js
 
 ; Flow doesn't support platforms
@@ -45,7 +45,7 @@ module.file_ext=.js
 module.file_ext=.json
 module.file_ext=.android.js
 
-# TODO(macOS GH#774):
+# macOS
 module.system.haste.name_reducers='^\(.*\)\.macos$' -> '\1'
 
 munge_underscores=true

.flowconfig.macos

@@ -1,5 +1,5 @@
 [ignore]
-; TODO(macOS GH#774)
+; macOS
 ; We fork some components by platform
 .*/*[.]ios.js
 .*/*[.]android.js
@@ -13,7 +13,7 @@
 ; Ignore "BUCK" generated dirs
 <PROJECT_ROOT>/\.buckd/
 
-; TODO(macOS GH#774): Ignore metro.config.js
+; macOS: Ignore metro.config.js
 <PROJECT_ROOT>/metro.config.js
 
 ; Flow doesn't support platforms

.github/workflows/test-docker-android.yml

@@ -1,4 +1,4 @@
-# TODO(macOS GH#774) - disable this test
+# macOS: disable this test
 
 # name: Test Docker Android Image
 # # This workflow is triggered on commits to main and pull requests.

IntegrationTests/LayoutEventsTest.js

@@ -13,7 +13,7 @@
 const React = require('react');
 const ReactNative = require('react-native');
 const {Image, LayoutAnimation, StyleSheet, Text, View} = ReactNative;
-const {Platform} = ReactNative; // TODO(macOS GH#774)
+const {Platform} = ReactNative; // [macOS]
 const {TestModule} = ReactNative.NativeModules;
 
 import type {ViewStyleProp} from 'react-native/Libraries/StyleSheet/StyleSheet';
@@ -54,8 +54,8 @@ class LayoutEventsTest extends React.Component<Props, State> {
   animateViewLayout() {
     debug('animateViewLayout invoked');
     LayoutAnimation.configureNext(
-      Platform.OS === 'macos' // [TODO(macOS GH#774)
-        ? LayoutAnimation.Presets.easeInEaseOut // ]TODO(macOS GH#774)
+      Platform.OS === 'macos' // [macOS
+        ? LayoutAnimation.Presets.easeInEaseOut // macOS]
         : LayoutAnimation.Presets.spring,
       () => {
         debug('animateViewLayout done');

Libraries/ActionSheetIOS/React-RCTActionSheet.podspec

@@ -24,7 +24,7 @@ Pod::Spec.new do |s|
   s.documentation_url      = "https://reactnative.dev/docs/actionsheetios"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0", :osx => "10.15" } # TODO(macOS GH#214)
+  s.platforms              = { :ios => "11.0", :osx => "10.15" } # macOS
   s.source                 = source
   s.source_files           = "*.{m}"
   s.preserve_paths         = "package.json", "LICENSE", "LICENSE-docs"

Libraries/Alert/Alert.js

@@ -24,21 +24,21 @@ export type Buttons = Array<{
   style?: AlertButtonStyle,
   ...
 }>;
-// [TODO(macOS GH#774)
+// [macOS
 export type DefaultInputsArray = Array<{
   default?: string,
   placeholder?: string,
   style?: AlertButtonStyle,
 }>;
-// ]TODO(macOS GH#774)
+// macOS]
 
 type Options = {
   cancelable?: ?boolean,
   onDismiss?: ?() => void,
-  // [TODO(macOS GH#774)
+  // [macOS
   modal?: ?boolean,
   critical?: ?boolean,
-  // ]TODO(macOS GH#774)
+  // macOS]
   ...
 };
 
@@ -56,7 +56,7 @@ class Alert {
   ): void {
     if (Platform.OS === 'ios') {
       Alert.prompt(title, message, buttons, 'default');
-      // [TODO(macOS ISS#2323203)
+      // [macOS
     } else if (Platform.OS === 'macos') {
       Alert.promptMacOS(
         title,
@@ -67,7 +67,7 @@ class Alert {
         options?.modal,
         options?.critical,
       );
-      // ]TODO(macOS ISS#2323203)
+      // macOS]
     } else if (Platform.OS === 'android') {
       const NativeDialogManagerAndroid =
         require('../NativeModules/specs/NativeDialogManagerAndroid').default;
@@ -170,15 +170,15 @@ class Alert {
           cb && cb(value);
         },
       );
-      // [TODO(macOS GH#774)
+      // [macOS
     } else if (Platform.OS === 'macos') {
       const defaultInputs = [{default: defaultValue}];
       Alert.promptMacOS(title, message, callbackOrButtons, type, defaultInputs);
     }
-    // ]TODO(macOS GH#774)
+    // macOS]
   }
 
-  // [TODO(macOS GH#774)
+  // [macOS
   /**
    * Create and display a prompt to enter some text.
    * @static
@@ -266,7 +266,7 @@ class Alert {
       },
     );
   }
-  // ]TODO(macOS GH#774)
+  // macOS]
 }
 
 module.exports = Alert;

Libraries/Alert/NativeAlertManager.js

@@ -20,11 +20,11 @@ export type Args = {|
   cancelButtonKey?: string,
   destructiveButtonKey?: string,
   keyboardType?: string,
-  // [TODO(macOS GH#774)
+  // [macOS
   defaultInputs?: Array<Object>,
   modal?: ?boolean,
   critical?: ?boolean,
-  // ]TODO(macOS GH#774)
+  // macOS]
 |};
 
 export interface Spec extends TurboModule {

Libraries/Alert/RCTAlertManager.macos.js

@@ -8,7 +8,7 @@
  * @flow strict-local
  */
 
-// TODO(macOS GH#774)
+// [macOS]
 
 /* $FlowFixMe allow macOS to share iOS file */
 const alertWithArgs = require('./RCTAlertManager.ios');

Libraries/Animated/AnimatedMock.js

@@ -98,11 +98,11 @@ const spring = function (
   return {
     ...emptyAnimation,
     start: mockAnimationStart((callback?: ?EndCallback): void => {
-      // [TODO(macOS GH#774) - setValue can't handle AnimatedNodes
+      // [macOS - setValue can't handle AnimatedNodes
       if (config.toValue instanceof AnimatedNode) {
         anyValue.setValue(config.toValue.__getValue());
       } else {
-        // ]TODO(macOS GH#774)
+        // [macOS]
         anyValue.setValue(config.toValue);
       }
       callback?.({finished: true});

Libraries/Animated/NativeAnimatedHelper.js

@@ -403,7 +403,7 @@ module.exports = {
       nativeEventEmitter = new NativeEventEmitter(
         // T88715063: NativeEventEmitter only used this parameter on iOS. Now it uses it on all platforms, so this code was modified automatically to preserve its behavior
         // If you want to use the native module on other platforms, please remove this condition and test its behavior
-        Platform.OS !== 'ios' && Platform.OS !== 'macos' // TODO(macOS GH#774): Also use this parameter on macOS
+        Platform.OS !== 'ios' && Platform.OS !== 'macos' // macOS: Also use this parameter on macOS
           ? null
           : NativeAnimatedModule,
       );

Libraries/AppState/AppState.js

@@ -51,7 +51,7 @@ class AppState {
         new NativeEventEmitter(
           // T88715063: NativeEventEmitter only used this parameter on iOS. Now it uses it on all platforms, so this code was modified automatically to preserve its behavior
           // If you want to use the native module on other platforms, please remove this condition and test its behavior
-          Platform.OS !== 'ios' && Platform.OS !== 'macos' // TODO(macOS GH#774): Also use this parameter on macOS
+          Platform.OS !== 'ios' && Platform.OS !== 'macos' // macOS: Also use this parameter on macOS
             ? null
             : NativeAppState,
         );

Libraries/Blob/React-RCTBlob.podspec

@@ -26,7 +26,7 @@ Pod::Spec.new do |s|
   s.homepage               = "https://reactnative.dev/"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0", :osx => "10.15" } # TODO(macOS GH#214)
+  s.platforms              = { :ios => "11.0", :osx => "10.15" } # macOS
   s.compiler_flags         = folly_compiler_flags + ' -Wno-nullability-completeness'
   s.source                 = source
   s.source_files           = "*.{h,m,mm}"