Enable Fabric test using Fabric C++ implementation

Summary:
This diff:
- Disables all tests but one of FabricViewTest
- Disables all tests but one of FabricBenchmarkTest
- Changes ReactAppTestActivity to run with Hermes

The reason there is only one test running in each test class, is because the tear down process of Fabric is still flaky and it produces crashes when restarting RN. We are working on this right now and we will enable the rest of the tests after that's fixed.

Reviewed By: achen1

Differential Revision: D9890700

fbshipit-source-id: a8716481eff15b77bd12b38aaaefd4e282c71f3b

Author: mdvacca

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactAppTestActivity.java

@@ -208,6 +208,9 @@ public void loadBundle(ReactInstanceSpecForTest spec, String bundleName, boolean
             .getReactInstanceManagerBuilder()
             .setApplication(getApplication())
             .setBundleAssetName(bundleName);
+    if (spec.getJavaScriptExecutorFactory() != null) {
+      builder.setJavaScriptExecutorFactory(spec.getJavaScriptExecutorFactory());
+    }
     if (!spec.getAlternativeReactPackagesForTest().isEmpty()) {
       builder.addPackages(spec.getAlternativeReactPackagesForTest());
     } else {

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactInstanceSpecForTest.java

@@ -9,12 +9,14 @@
 
 import android.annotation.SuppressLint;
 import com.facebook.react.ReactPackage;
+import com.facebook.react.bridge.JavaScriptExecutorFactory;
 import com.facebook.react.bridge.JavaScriptModule;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.uimanager.ViewManager;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import javax.annotation.Nullable;
 
 /**
  * A spec that allows a test to add additional NativeModules/JS modules to the ReactInstance. This
@@ -29,12 +31,18 @@ public class ReactInstanceSpecForTest {
   private final List<Class<? extends JavaScriptModule>> mJSModuleSpecs = new ArrayList<>();
   private final List<ViewManager> mViewManagers = new ArrayList<>();
   private final ArrayList<ReactPackage> mReactPackages = new ArrayList<>();
+  @Nullable private JavaScriptExecutorFactory mJavaScriptExecutorFactory = null;
 
   public ReactInstanceSpecForTest addNativeModule(NativeModule module) {
     mNativeModules.add(module);
     return this;
   }
 
+  public ReactInstanceSpecForTest setJavaScriptExecutorFactory(JavaScriptExecutorFactory javaScriptExecutorFactory) {
+    mJavaScriptExecutorFactory = javaScriptExecutorFactory;
+    return this;
+  }
+
   public ReactInstanceSpecForTest setPackage(ReactPackage reactPackage) {
     if (!mReactPackages.isEmpty()) {
       throw new IllegalStateException(
@@ -66,6 +74,11 @@ public ReactPackage getAlternativeReactPackageForTest() {
     return mReactPackages.get(0);
   }
 
+  @Nullable
+  public JavaScriptExecutorFactory getJavaScriptExecutorFactory() {
+    return mJavaScriptExecutorFactory;
+  }
+
   public List<ReactPackage> getAlternativeReactPackagesForTest() {
     return mReactPackages;
   }

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactInstrumentationTest.java

@@ -11,9 +11,11 @@
 import android.test.ActivityInstrumentationTestCase2;
 import android.view.View;
 import android.view.ViewGroup;
+import com.facebook.react.bridge.JavaScriptExecutorFactory;
 import com.facebook.react.bridge.JavaScriptModule;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.testing.idledetection.IdleWaiter;
+import javax.annotation.Nullable;
 
 /**
  * Base class for instrumentation tests that runs React based application.
@@ -27,6 +29,9 @@ public abstract class ReactInstrumentationTest extends
 
   protected StringRecordingModule mRecordingModule;
 
+  @Nullable
+  protected JavaScriptExecutorFactory mJavaScriptExecutorFactory = null;
+
   public ReactInstrumentationTest() {
     super(ReactAppTestActivity.class);
   }
@@ -49,7 +54,7 @@ protected void setUp() throws Exception {
   /**
    * Renders this component within this test's activity
    */
-  public void renderComponent(final String componentName) throws Exception {
+  public void renderComponent(final String componentName) {
     getActivity().renderComponent(componentName, null);
     waitForBridgeAndUIIdle();
   }
@@ -98,7 +103,12 @@ protected <T extends JavaScriptModule> T getJSModule(Class<T> jsInterface) {
    * Override this method to provide extra native modules to be loaded before the app starts
    */
   protected ReactInstanceSpecForTest createReactInstanceSpecForTest() {
-    return new ReactInstanceSpecForTest().addNativeModule(mRecordingModule);
+    ReactInstanceSpecForTest reactInstanceSpecForTest =
+      new ReactInstanceSpecForTest().addNativeModule(mRecordingModule);
+    if (mJavaScriptExecutorFactory != null) {
+      reactInstanceSpecForTest.setJavaScriptExecutorFactory(mJavaScriptExecutorFactory);
+    }
+    return reactInstanceSpecForTest;
   }
 
   /**

ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java

@@ -25,7 +25,6 @@
 import com.facebook.react.common.annotations.VisibleForTesting;
 import com.facebook.systrace.Systrace;
 import com.facebook.systrace.TraceListener;
-import java.lang.annotation.Native;
 import java.lang.ref.WeakReference;
 import java.util.ArrayList;
 import java.util.Collection;

ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java

@@ -7,10 +7,9 @@
 
 package com.facebook.react.bridge;
 
-import javax.annotation.Nullable;
-
 import com.facebook.jni.HybridData;
 import com.facebook.proguard.annotations.DoNotStrip;
+import javax.annotation.Nullable;
 
 /**
  * JavaScript executor that delegates JS calls processed by native code back to a java version