Skip to content

Commit 99890bf

Browse files
ryancatfacebook-github-bot
authored andcommitted
Move RedBoxHandler interface to the proper interfaces directory
Summary: We put the `:interfaces` target on the dependencies list for `:devsupport` target in the [BUCK file](https://fburl.com/code/lrr1c0pn). In the following diffs I will need to put the interface [`/devsupport/RedBoxHandler`](https://fburl.com/code/v53euvps) on to [`/devsupport/interfaces/DevSupportManager`](https://fburl.com/code/k8gwxa0f). This violates the dependency rule. Since `RedBoxHandler` is an interface, I moved it to the interfaces list in this diff to unblock. Changelog: [Android][Internal] Reviewed By: yungsters Differential Revision: D33987834 fbshipit-source-id: 77a1ee14bd10c6bbaac2ee465ae7050e99ed0399
1 parent d1c2458 commit 99890bf

File tree

9 files changed

+10
-7
lines changed

9 files changed

+10
-7
lines changed

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@
8181
import com.facebook.react.config.ReactFeatureFlags;
8282
import com.facebook.react.devsupport.DevSupportManagerFactory;
8383
import com.facebook.react.devsupport.ReactInstanceDevHelper;
84-
import com.facebook.react.devsupport.RedBoxHandler;
8584
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
8685
import com.facebook.react.devsupport.interfaces.DevSupportManager;
8786
import com.facebook.react.devsupport.interfaces.PackagerStatusCallback;
87+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
8888
import com.facebook.react.modules.appearance.AppearanceModule;
8989
import com.facebook.react.modules.appregistry.AppRegistry;
9090
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
import com.facebook.react.common.SurfaceDelegateFactory;
2727
import com.facebook.react.devsupport.DefaultDevSupportManagerFactory;
2828
import com.facebook.react.devsupport.DevSupportManagerFactory;
29-
import com.facebook.react.devsupport.RedBoxHandler;
3029
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
3130
import com.facebook.react.devsupport.interfaces.DevSupportManager;
31+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
3232
import com.facebook.react.jscexecutor.JSCExecutor;
3333
import com.facebook.react.jscexecutor.JSCExecutorFactory;
3434
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;

ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import com.facebook.react.common.SurfaceDelegate;
1919
import com.facebook.react.common.SurfaceDelegateFactory;
2020
import com.facebook.react.devsupport.DevSupportManagerFactory;
21-
import com.facebook.react.devsupport.RedBoxHandler;
21+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
2222
import com.facebook.react.uimanager.UIImplementationProvider;
2323
import java.util.List;
2424

ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgeDevSupportManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
2828
import com.facebook.react.devsupport.interfaces.DevOptionHandler;
2929
import com.facebook.react.devsupport.interfaces.DevSplitBundleCallback;
30+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
3031
import com.facebook.react.packagerconnection.RequestHandler;
3132
import java.io.File;
3233
import java.io.IOException;

ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.facebook.react.common.SurfaceDelegateFactory;
1313
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
1414
import com.facebook.react.devsupport.interfaces.DevSupportManager;
15+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
1516
import com.facebook.react.packagerconnection.RequestHandler;
1617
import java.lang.reflect.Constructor;
1718
import java.util.Map;

ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
import com.facebook.react.devsupport.interfaces.ErrorCustomizer;
5252
import com.facebook.react.devsupport.interfaces.ErrorType;
5353
import com.facebook.react.devsupport.interfaces.PackagerStatusCallback;
54+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
5455
import com.facebook.react.devsupport.interfaces.StackFrame;
5556
import com.facebook.react.modules.core.RCTNativeAppEventEmitter;
5657
import com.facebook.react.packagerconnection.RequestHandler;

ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.facebook.react.common.SurfaceDelegateFactory;
1313
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
1414
import com.facebook.react.devsupport.interfaces.DevSupportManager;
15+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
1516
import com.facebook.react.packagerconnection.RequestHandler;
1617
import java.util.Map;
1718

ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@
3131
import com.facebook.react.R;
3232
import com.facebook.react.common.MapBuilder;
3333
import com.facebook.react.common.ReactConstants;
34-
import com.facebook.react.devsupport.RedBoxHandler.ReportCompletedListener;
3534
import com.facebook.react.devsupport.interfaces.DevSupportManager;
35+
import com.facebook.react.devsupport.interfaces.RedBoxHandler;
36+
import com.facebook.react.devsupport.interfaces.RedBoxHandler.ReportCompletedListener;
3637
import com.facebook.react.devsupport.interfaces.StackFrame;
3738
import okhttp3.MediaType;
3839
import okhttp3.OkHttpClient;

ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxHandler.java renamed to ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/RedBoxHandler.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
package com.facebook.react.devsupport;
8+
package com.facebook.react.devsupport.interfaces;
99

1010
import android.content.Context;
1111
import android.text.SpannedString;
1212
import androidx.annotation.Nullable;
13-
import com.facebook.react.devsupport.interfaces.ErrorType;
14-
import com.facebook.react.devsupport.interfaces.StackFrame;
1513

1614
/**
1715
* Interface used by {@link BridgeDevSupportManager} to allow interception on any redboxes during

0 commit comments

Comments
 (0)