fix for issue 687 #688
Open
fix for issue 687 #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users open the left navigation menu (hamburger menu), the main content completely disappears, leaving a blank view. This happens on both the Home page and all other pages when the drawer is activated
Why
Accessibility violation - Content becomes completely inaccessible when drawer is open
Poor UX - Users lose context and can't see the current page while navigating
Navigation confusion - Users can't understand where they are or what they're navigating to
Resolves [Add Relevant Issue Here]
What
// CORRECT: Semi-transparent backdrop with proper layering
<Animated.View
style={{
position: 'absolute',
top: 0, left: 0, right: 0, bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.3)', // Semi-transparent
opacity: fadeAnim,
zIndex: 1 // Behind drawer, over content
}}>
<Pressable
style={{ flex: 1 }}
onPress={() => setDrawerDesiredOpen(false)}
accessibilityRole="button"
accessibilityLabel="Close navigation menu"
/>
</Animated.View>
Screenshots
Before
After
Microsoft Reviewers: Open in CodeFlow