Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DevInternalSettings with DeveloperSettings for react-native 0.73.0 #2617

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Replace DevInternalSettings with DeveloperSettings for react-native 0.73.0 #2617

merged 4 commits into from
Jan 17, 2024

Conversation

DmitriyKirakosyan
Copy link
Contributor

DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings.

#2601
AB#103487

@DmitriyKirakosyan
Replace DevInternalSettings with DeveloperSettings
af7b9ab 
DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings.
facebook/react-native#37256
@DmitriyKirakosyan DmitriyKirakosyan requested a review from a team as a code owner November 9, 2023 11:33
lucen-ms
lucen-ms previously approved these changes Nov 9, 2023
View reviewed changes
@velimirj
Copy link

velimirj commented Nov 9, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 2617 in repo microsoft/react-native-code-push

@lucen-ms
Copy link

lucen-ms commented Nov 9, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@serybva
Copy link

serybva commented Dec 14, 2023

Hey guys, any plans to merge this soon? @lucen-ms @velimirj

@larsmunkholm
Copy link

I need this

This was referenced Jan 3, 2024
Closed
Closed
Closed
@agusvazquez
Copy link

Can we merge this? Right now 0.73 is broken. I made it work using a patch.

@yevhenlv
Copy link

yevhenlv commented Jan 4, 2024

Can't update RN version.... hope for faster result)

@lernerb
Copy link

lernerb commented Jan 5, 2024

This is blocking multiple production apps from using react native code push, and is making us reconsider using it long term if it's not going to be supported in a timely manner. It's been two months, is this getting fixed or not?

@lernerb
Copy link

lernerb commented Jan 6, 2024

Also bumping for visibility to @AnatolyPristensky 👍

@agusvazquez
Copy link

For all facing this issue, you can use this tool as a temporal fix until this is merged and released.

https://www.npmjs.com/package/patch-package

@caiodeambrosio
Copy link

need this

@aderiushev
Copy link

need this!

@huextrat
Copy link

Hi @DmitriyKirakosyan @AnatolyPristensky @velimir-jankovic Can one of you press the green button please?

@mchtkuk
Copy link

mchtkuk commented Jan 15, 2024

need this

@DmitriyKirakosyan DmitriyKirakosyan merged commit 99c8c4e into master Jan 17, 2024
3 checks passed
@DmitriyKirakosyan DmitriyKirakosyan deleted the support-rn-0.73 branch January 17, 2024 15:44
@olegklimakov
Copy link

Hi. Any plans to release this change?

@caiodeambrosio
Copy link

Release please 🙏🏽😬

@AnatolyPristensky
Copy link
Contributor

@caiodeambrosio, release 8.2.0 is available.

@larsmunkholm
Copy link

larsmunkholm commented Jan 23, 2024 •
edited
Loading

@caiodeambrosio, release 8.2.0 is available.

There's a bug, so maybe wait
#2649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velimirj velimirj velimirj approved these changes

@huextrat huextrat huextrat approved these changes

@Dallas62 Dallas62 Dallas62 approved these changes

@velimir-jankovic velimir-jankovic velimir-jankovic left review comments

@lucen-ms lucen-ms lucen-ms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.