Fixed issue with [Android] restartApp() throwing exception w/ release build (#861)

* Fixed issue with error on parsing plist path

See #534 (comment) for details

* Fixed issue with [Android] restartApp() throwing exception w/ release build

#847

* Changed return value to null for getUpdateMetadata instead of empty string

In accordance with docs and #862

* Code refactoring: moved variable assignment out of loop

Author: Max

android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java

@@ -105,10 +105,12 @@ private void setJSBundle(ReactInstanceManager instanceManager, String latestJSBu
             Field bundleLoaderField = instanceManager.getClass().getDeclaredField("mBundleLoader");
             Class<?> jsBundleLoaderClass = Class.forName("com.facebook.react.cxxbridge.JSBundleLoader");
             Method createFileLoaderMethod = null;
+            String createFileLoaderMethodName = latestJSBundleFile.toLowerCase().startsWith("assets://")
+                        ? "createAssetLoader" : "createFileLoader";
 
             Method[] methods = jsBundleLoaderClass.getDeclaredMethods();
-            for (Method method : methods) {
-                if (method.getName().equals("createFileLoader")) {
+            for (Method method : methods) {               
+                if (method.getName().equals(createFileLoaderMethodName)) {
                     createFileLoaderMethod = method;
                     break;
                 }
@@ -125,7 +127,7 @@ private void setJSBundle(ReactInstanceManager instanceManager, String latestJSBu
                 // RN >= v0.34
                 latestJSBundleLoader = createFileLoaderMethod.invoke(jsBundleLoaderClass, latestJSBundleFile);
             } else if (numParameters == 2) {
-                // RN >= v0.31 && RN < v0.34
+                // RN >= v0.31 && RN < v0.34 or AssetLoader instance
                 latestJSBundleLoader = createFileLoaderMethod.invoke(jsBundleLoaderClass, getReactApplicationContext(), latestJSBundleFile);
             } else {
                 throw new NoSuchMethodException("Could not find a recognized 'createFileLoader' method");