Restore fancy error reporting in Python #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the way we pull features for miette such that the wasm crate preserves the ASCII-based "fancy-no-syscall" behavior needed for broader extension/web compatibility, while allowing the native pip crate to use full "fancy" and have colors and symbols for improved readability. Fixes #1898
swernli
requested review from
idavis,
minestarks,
billti and
ivanbasov
as code owners
idavis
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the way we pull features for miette such that the wasm crate preserves the ASCII-based "fancy-no-syscall" behavior needed for broader extension/web compatibility, while allowing the native pip crate to use full "fancy" and have colors and symbols for improved readability.
Before:
After:
Existing behavior (and reduced dependencies) preserved in VS Code:
Fixes #1898